Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically open sidebar for current folder if the screen size allows it #7138

Closed
jancborchardt opened this issue Nov 10, 2017 · 19 comments · Fixed by #39808
Closed

Automatically open sidebar for current folder if the screen size allows it #7138

jancborchardt opened this issue Nov 10, 2017 · 19 comments · Fixed by #39808
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@jancborchardt
Copy link
Member

This is something we talked about at the conference: If the screen width is above a certain value, we could automatically open the sidebar for the folder you are currently in.

That would help make the things we offer in the sidebar like comments and sharing more obvious and directly accessible.

The only question is what we do in the root folder. For the first iteration we could simply not show the sidebar. In the future we could show the activity tab and simply show all activity like in the Activity app. cc @nickvergessen

What do you think @nextcloud/designers?

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files labels Nov 10, 2017
@jancborchardt jancborchardt added this to the Nextcloud 14 milestone Nov 10, 2017
@skjnldsv
Copy link
Member

I completely agree! We have far too much empty space on big screens :)

@jancborchardt
Copy link
Member Author

How could we do it? I guess we need JS for it @nextcloud/javascript

@nickvergessen
Copy link
Member

In the future we could show the activity tab and simply show all activity like in the Activity app.

Sorry, but please don't turn the files app into a portal/dashboard/whatever...

@jancborchardt
Copy link
Member Author

  • in the sidebar of a file, the activity tab shows activity on the file
  • in the sidebar of a folder, ideally activity of the whole folder is shown but is not atm due to technical reasons
  • in the root folder, the sidebar could show all activity

It's not about turning the Files app into anything, it's providing info where it's expected or useful.

As said above, as another solution, in the root folder we could also simply not show the sidebar.

@Espina2
Copy link
Contributor

Espina2 commented Nov 11, 2017

In the frontend you can do that with a flag. So you verify with javascript what is the window width, if is bigger than X set the flag to true.

And you will have something like that, if the flag is true onclick do this. That is something easy todo.

I am not really sure about showing the bar, it can look weird. Maybe we should do it first and take the decision after. @jancborchardt

@blizzz
Copy link
Member

blizzz commented Nov 11, 2017

Directory activities would recursively get the activities of their children? Sounds expensive, if not pre-generated.

@jancborchardt
Copy link
Member Author

jancborchardt commented Nov 12, 2017

@blizzz activity is a differnt discussion for now (can't find the issue). This is only about having the sidebar open, with the Sharing tab showing by default.

@nickvergessen
Copy link
Member

activity is a differnt discussion for now (can't find the issue). This is only about having the sidebar open, with the Sharing tab showing by default.

nextcloud/activity#45

@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Nov 21, 2017
@danxuliu
Copy link
Member

If the screen width is above a certain value, we could automatically open the sidebar for the folder you are currently in.

What would be the value (or values) to open the sidebar by default? This is similar to something planned for Nextcloud Talk, so it would be good to behave consistently (if it makes sense, of course).

@nickvergessen
Copy link
Member

I would show it on full HD already.

bildschirmfoto vom 2017-11-29 um 09 58 43

Content area looks still big enough to me, and an average user doesn't have too long file names, so the 750px of the file name column wouldn't be enough.

@jancborchardt
Copy link
Member Author

Yep, on full HD absolutely. @danxuliu can you prepare a PR with that value to start with, then we can test and see what needs to be adjusted?

@danxuliu
Copy link
Member

danxuliu commented Dec 1, 2017

@jancborchardt

can you prepare a PR with that value to start with, then we can test and see what needs to be adjusted?

Please see nextcloud/spreed#516 I will work on the PR for server once it is open again for new features... and I have some time ;-)

@Abijeet
Copy link
Member

Abijeet commented Apr 18, 2018

I can take a crack at this some at point in the next two weeks,

@nextcloud/designers, Here's what I think we should do if the page size is enough for the details section to be shown,

  1. On page load, display the details section with the details of the first file.
  2. If I click on a folder, currently the sidebar closes, so after the folder contents are loaded, open the sidebar again displaying the details of the first file.
  3. Sorting the files will not change the currently automatically selected file. This means that since we are showing the details of the first file on page load, sorting will continue to show that file details even though it may not be first anymore.
  4. If no files are present, details section will remain collapsed.
  5. If a folder is empty, and a new file is uploaded, the details section will automatically open for that file.
  6. If the file whose details are currently shown is deleted, show the details of the next file.

Doubts

  1. If the user closes the auto-opened details section, the next time he goes into a new folder or refreshes the page should the details section still open?

That's all I can think of right now. Will comment if I have anything else.

@Abijeet
Copy link
Member

Abijeet commented May 7, 2018

@jancborchardt - What do you think of my previous comment?

@jancborchardt
Copy link
Member Author

@Abijeet sorry, here’s my feedback :)

On page load, display the details section with the details of the first file.

We should actually show the details of this folder itself. This also solves your other comments too. :)

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@MorrisJobke
Copy link
Member

Nothing for 14 it seems -> moved to 15

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 29, 2018
@MorrisJobke MorrisJobke removed this from the Nextcloud 14 milestone Jun 29, 2018
@brasofilo
Copy link

Hi folks, the request was removed from Nextcloud 18 milestone and I'm not seeing it on 19 milestones either...
There's no workaround to have the sidebar permanently opened, is it?

@skjnldsv
Copy link
Member

Not yet, this is soon coming though.
Will be implemented slowly but surely in all the apps that supports it until all Nextcloud supports it :)

@schnellschnell
Copy link

I have a project that needs the comment section always open in browsers. Is there a hack or an app or anything to begin with? I'd like to develop something that can be used by anybody later. I have some modest time and funding for that project. Have you tried something or is anybody interested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.