-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags icon is too bright #626
Comments
Ah – that’s because it should be black instead of grey :) The greying is handled via CSS. Can you change that @Bugsbane? |
I'd already adjusted the icon to a black, optimized version in my own repo, but I've also made a number of unfinished changes on my repo for another issue, so I'm not entirely sure how to do a pull request via Github just for that one file change, and not the others. Anyone's welcome to commit the file at https://github.com/Bugsbane/server/blob/master/apps/files/img/recent.svg though |
@Bugsbane I will cherry-pick your commit to another branch on my fork 😉 For the future: Fix unrelated bugs in seperate branches, so that you can commit them seperate. |
Damn... We are talking about tags here and not about recent-file listing 😁 @Bugsbane |
Ah, sorry! I was working on both icons and got mixed up. Cherry pick these commits for a black version of the tag icon (SVG and PNG): |
@Bugsbane THX. Please check this again. Do we need the png. Should it not be 16x16. |
sigh Clearly I should be sleeping instead of committing! Yes it should be 16x16px. My understanding is that the PNG's are used as a fallback on older IE's that don't support SVG. Not sure if that's still relevant, though. Anyway, here's the 16x16px version: |
@Bugsbane May I ask you to make your commit (png and svg replacing) to this branch: |
Fixed by #764 |
To solve #232, #311 introduced a new icon for the tags app (which is very nice). The problem is, that the color is still not matching with the other icons in the sidebar 😁 The grey is too bright.
@jancborchardt @Bugsbane @nextcloud/designers
The text was updated successfully, but these errors were encountered: