Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: Background image #5035

Closed
tobiasKaminsky opened this issue May 22, 2017 · 5 comments
Closed

Theming: Background image #5035

tobiasKaminsky opened this issue May 22, 2017 · 5 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: theming

Comments

@tobiasKaminsky
Copy link
Member

I am currently developing the usage of the background image for android app and I have some questions:

  • How can I know if the background image has been changed? The url stays the same.
  • Is there a way to get a resized version of it? I want to prevent that some admin uses a 2mb image and this gets loaded into our app as this costs data and reduces the speed of opening the sidebar.
@enoch85
Copy link
Member

enoch85 commented May 22, 2017

cc @marinofaggiana

@juliusknorr
Copy link
Member

How can I know if the background image has been changed? The url stays the same.

The URL should at least have a different cachebuster value e.g. v=1. Can you check that?

Is there a way to get a resized version of it? I want to prevent that some admin uses a 2mb image and this gets loaded into our app as this costs data and reduces the speed of opening the sidebar.

The background image will be scaled to 1920px width and saved as jpeg with 75% quality on upload. Not sure if that is enough or if we should add some endpoint to request smaller versions. @nextcloud/theming

@juliusknorr juliusknorr added 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: theming labels May 23, 2017
@LukasReschke
Copy link
Member

Is there a way to get a resized version of it? I want to prevent that some admin uses a 2mb image and this gets loaded into our app as this costs data and reduces the speed of opening the sidebar.

Can't you do that in a background job or so? :)

@marinofaggiana
Copy link
Member

Download the image in background, not in main thread, when done refresh

@tobiasKaminsky
Copy link
Member Author

It is not about UI lagging but about preserving bandwidth.
But if it is scaled down, I think is enough.
@juliushaertl indeed there is a "v=9" in the url, so this is enough to see updated background images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: theming
Projects
None yet
Development

No branches or pull requests

5 participants