Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.2.4.3/3.1 - Note: When the Settings menu is open, it is only possible to exit the menu using the ESC key. (3) #41875

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 6 comments
Assignees
Labels

Comments

@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@ShGKme ShGKme self-assigned this Nov 29, 2023
@szaimen
Copy link
Contributor

szaimen commented Dec 4, 2023

What is the expected behaviour here?

@ShGKme
Copy link
Contributor

ShGKme commented Dec 4, 2023

What is the expected behaviour here?

This menu should work the same way as other menus and NcAction:

  • Arrows should be used to navigate between elements of an interactive component
  • TAB should be used to navigate between interactive components

So, here pressing TAB should close the menu and navigate to the next interactive component. Same as on desktop apps.

@Pytal Pytal assigned Pytal and unassigned ShGKme Jan 4, 2024
@Pytal
Copy link
Member

Pytal commented Jan 10, 2024

I have been looking into the W3 patterns and possible implementations for this case, , Tab nav etc., but this pattern does not make sense in this case as we'd already concluded that this is not an application menu but a FlyOut menu, ref #37095 (comment)

Can you confirm that the menu in the screenshot above is a FlyOut menu and therefore does not require application menu-like navigation @michaelnissenbaum?

edit: Also for escaping I believe we had already agreed that focus trapping this, though not required, was valid so only being able to exit the menu with Esc or clicking outside is sufficient

@michaelnissenbaum
Copy link

From my perspective, this is a FlyOut menu. Navigation through the menu items should be done using the TAB key. When the last item in the menu is reached, it would be best if pressing the TAB key shifts the keyboard focus to the next interactive element in the DOM while simultaneously closing the menu. As an example, you can refer to the following page, which provides a menu button in its mobile view - https://www.bmas.de/EN/Service/Press/News/2020/online-accessibility-monitoring-authority.html.

@szaimen
Copy link
Contributor

szaimen commented Jan 26, 2024

I am not sure how this should work in the end but if I read correctly reaching the end of the list should directly focus on the next element in the dom, no? Currently it seems like still the ESC button is enforced at least on stable28

See

Aufzeichnung.2024-01-26.093729.mp4

@szaimen szaimen reopened this Jan 26, 2024
@Pytal
Copy link
Member

Pytal commented Jan 26, 2024

I am not sure how this should work in the end but if I read correctly reaching the end of the list should directly focus on the next element in the dom, no?

Yes that's the correct behaviour and works on master, still needs stable28 to be unfrozen for dep update merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants