Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Phone number is no longer saved #41760

Closed
4 of 8 tasks
ChristophWurst opened this issue Nov 27, 2023 · 9 comments
Closed
4 of 8 tasks

[Bug]: Phone number is no longer saved #41760

ChristophWurst opened this issue Nov 27, 2023 · 9 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish 28-feedback bug regression

Comments

@ChristophWurst
Copy link
Member

⚠️ This issue respects the following points: ⚠️

Bug description

Entering a phone number in the personal settings should trigger a save operation, either automaticlaly or when I click Enter

image

Steps to reproduce

  1. Open personal settings
  2. Enter a phone number
  3. Wait a minute
  4. Reload the page

Expected behavior

The phone number is saved.

Installation method

None

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ChristophWurst ChristophWurst added bug 1. to develop Accepted and waiting to be taken care of regression 28-feedback labels Nov 27, 2023
@ChristophWurst
Copy link
Member Author

Other fields, like location or organization behave strange too:

  1. I see an error toast
  2. My modifications are discarded, the previous state is restored

image

@ChristophWurst
Copy link
Member Author

@Pytal @ShGKme could you have a look?

https://github.com/nextcloud/server/commits/stable28/apps/settings/src/components/PersonalInfo

@ShGKme
Copy link
Contributor

ShGKme commented Nov 27, 2023

Password confirmation dialog already mounted

@ShGKme
Copy link
Contributor

ShGKme commented Nov 27, 2023

I'm able to reproduce on c.nc.c, but unable to reproduce locally. Neither on master, nor on 28.0.0-rc.1...

@ChristophWurst
Copy link
Member Author

Could it depend on the apps installed and loaded?

@ShGKme
Copy link
Contributor

ShGKme commented Nov 27, 2023

Could it depend on the apps installed and loaded?

Kind of.

It is a conflict between @nextcloud/password-confirmation and new GlobalSearchModal.

After #41669 the GlobalSearchModal is always rendered, even if it was not opened. So initially there is a hidden GlobalSearchModal on the page.

At the same time, when @nextcloud/password-confirmation is rendered, it searches for a modal, and if there is a modal, it renders inside the last one opened modal.

See: nextcloud-libraries/nextcloud-password-confirmation#387

As the result - @nextcloud/password-confirmation modal is rendered inside hidden GlobalSearchModal and not vissible.

@Pytal

This comment was marked as outdated.

@Pytal
Copy link
Member

Pytal commented Nov 28, 2023

Please ignore the hidden outdated comment above @fenn-cs as @ShGKme found an alternative solution :)

@Pytal
Copy link
Member

Pytal commented Nov 28, 2023

Fixed by #41809

@Pytal Pytal closed this as completed Nov 28, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish 28-feedback bug regression
Projects
None yet
Development

No branches or pull requests

3 participants