Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue component lib bump bug with NcAppSettingsDialog #41025

Closed
Pytal opened this issue Oct 21, 2023 · 0 comments · Fixed by nextcloud-libraries/nextcloud-vue#4682
Closed

Vue component lib bump bug with NcAppSettingsDialog #41025

Pytal opened this issue Oct 21, 2023 · 0 comments · Fixed by nextcloud-libraries/nextcloud-vue#4682
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug

Comments

@Pytal
Copy link
Member

Pytal commented Oct 21, 2023

When testing the vue component lib bump and opening the Files settings dialog NcModal is not found

image

with error

[Vue warn]: Unknown custom element: <NcModal> - did you register the component correctly? For recursive components, make sure to provide the "name" option.

found in

---> <NcDialog>
       <NcAppSettingsDialog>
         <Settings> at apps/files/src/views/Settings.vue
           <NcAppNavigation>
             <Root>

This seems to be related to nextcloud-libraries/nextcloud-vue#4550, does this reproduce for you @susnux ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NcDialog): NcModal registration nextcloud-libraries/nextcloud-vue
2 participants
@Pytal @szaimen