Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Bug User management table view regressions #38245

Closed
5 of 9 tasks
ChristophWurst opened this issue May 15, 2023 · 6 comments
Closed
5 of 9 tasks

[BITV]: Bug User management table view regressions #38245

ChristophWurst opened this issue May 15, 2023 · 6 comments

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented May 15, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

#37870 introduced two regressions

  1. table doesn't align, td columns float to the left
  2. actions background element doesn't match row background
    Bildschirmfoto vom 2023-05-12 12-02-14
  3. Overlapping text while the user list loads
    image

Steps to reproduce

  1. Install Nextcloud
  2. Open the user management page
  3. Add at least one user

Expected behavior

Columns align & good design

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

N/a

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ChristophWurst
Copy link
Member Author

ChristophWurst commented May 15, 2023

0d3df2c is the first bad commit on the master branch

@ChristophWurst
Copy link
Member Author

$ git bisect bad
cb852ef is the first bad commit
commit cb852ef

The previous UI didn't have a hover state so white on white was ok
Now hover is gray -> white on gray

@ChristophWurst
Copy link
Member Author

@JuliaKirschenheuter is this fixable for RC2?

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter is this fixable for RC2?

i will try to fix it for RC2

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels May 23, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title [Bug]: User management table view regressions [BITV]: Bug User management table view regressions May 23, 2023
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels May 23, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this May 25, 2023
@JuliaKirschenheuter
Copy link
Contributor

regression can be closed, initial issue was reopened: #36921

@ChristophWurst
Copy link
Member Author

#38474 will fix the issue for 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants