Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the list/gallery view button does not work in public view anymore #33847

Closed
szaimen opened this issue Sep 2, 2022 · 6 comments · Fixed by #34071 or #34292
Closed

the list/gallery view button does not work in public view anymore #33847

szaimen opened this issue Sep 2, 2022 · 6 comments · Fixed by #34071 or #34292
Assignees
@PVince81
Labels
2. developing Work in progress bug regression ui-refresh-feedback
Milestone
Nextcloud 25

Comments

@szaimen
Copy link
Contributor

szaimen commented Sep 2, 2022

See

2022-09-02-112026.mp4
@szaimen
Copy link
Contributor Author

szaimen commented Sep 2, 2022

The other buttons for sorting like name and size are also not working anymore
See

2022-09-02-121709.mp4

@PVince81
Copy link
Member

sorting works for me on master in the "shared with others" view

however as you said the gallery view button is broken
I suspect it might be related to the switch from ids to class names

@PVince81 PVince81 self-assigned this Sep 14, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Sep 14, 2022
@PVince81 PVince81 mentioned this issue Sep 14, 2022
Merged
@PVince81
Copy link
Member

grid view toggle fix is here: #34071

@szaimen
Copy link
Contributor Author

szaimen commented Sep 27, 2022

@PVince81 I think it doesn't work on publish shares as well, so there is probably something missing still...

@szaimen szaimen reopened this Sep 27, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Sep 27, 2022

Yes, just tested. This button doesn't work on latest RC:
image

@szaimen szaimen changed the title the list/gallery view button does not work in any of the other views anymore the list/gallery view button does not work in public view anymore Sep 27, 2022
@PVince81 PVince81 mentioned this issue Sep 27, 2022
Merged
@PVince81
Copy link
Member

@szaimen fix is here: #34292

because the code was moved to a higher level, it needs to be done there as well

@szaimen szaimen added the 2. developing Work in progress label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PVince81 PVince81

Labels
2. developing Work in progress bug regression ui-refresh-feedback
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging a pull request may close this issue.

Fix grid view toggle nextcloud/server
Fix grid view button in public page nextcloud/server
2 participants
@PVince81 @szaimen