Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewController don't fire same event 5 times #33547

Closed
PVince81 opened this issue Aug 15, 2022 · 2 comments · Fixed by #33548
Closed

ViewController don't fire same event 5 times #33547

PVince81 opened this issue Aug 15, 2022 · 2 comments · Fixed by #33548

Comments

@PVince81
Copy link
Member

3rdparty/doctrine/dbal/src/Connection.php 1045 OC\DB\BacktraceDebugStack->startQuery
lib/private/DB/Connection.php 261 Doctrine\DBAL\Connection->executeQuery
3rdparty/doctrine/dbal/src/Query/QueryBuilder.php 345 OC\DB\Connection->executeQuery
lib/private/DB/QueryBuilder/QueryBuilder.php 281 Doctrine\DBAL\Query\QueryBuilder->execute
lib/private/Files/Cache/Cache.php 166 OC\DB\QueryBuilder\QueryBuilder->execute
lib/private/Files/Cache/HomeCache.php 85 OC\Files\Cache\Cache->get
lib/private/Files/View.php 1338 OC\Files\Cache\HomeCache->get
lib/private/Files/View.php 1389 OC\Files\View->getCacheEntry
lib/private/Files/Node/Root.php 205 OC\Files\View->getFileInfo
lib/private/Files/Node/Folder.php 137 OC\Files\Node\Root->get
apps-extra/spreed/lib/TInitialState.php 133 OC\Files\Node\Folder->get
apps-extra/spreed/lib/Files/TemplateLoader.php 97 OCA\Talk\Files\TemplateLoader->publishInitialStateForUser
lib/private/EventDispatcher/ServiceEventListener.php 87 OCA\Talk\Files\TemplateLoader->handle
3rdparty/symfony/event-dispatcher/EventDispatcher.php 251 OC\EventDispatcher\ServiceEventListener->__invoke
3rdparty/symfony/event-dispatcher/EventDispatcher.php 73 Symfony\Component\EventDispatcher\EventDispatcher->callListeners
lib/private/EventDispatcher/EventDispatcher.php 88 Symfony\Component\EventDispatcher\EventDispatcher->dispatch
lib/private/EventDispatcher/EventDispatcher.php 100 OC\EventDispatcher\EventDispatcher->dispatch
apps/files_sharing/list.php 49 OC\EventDispatcher\EventDispatcher->dispatchTyped
apps/files/lib/Controller/ViewController.php 136 include
apps/files/lib/Controller/ViewController.php 283 OCA\Files\Controller\ViewController->renderScript
lib/private/AppFramework/Http/Dispatcher.php 225 OCA\Files\Controller\ViewController->index
lib/private/AppFramework/Http/Dispatcher.php 133 OC\AppFramework\Http\Dispatcher->executeController
lib/private/AppFramework/App.php 172 OC\AppFramework\Http\Dispatcher->dispatch
lib/private/Route/Router.php 298 OC\AppFramework\App::main
lib/base.php 1033 OC\Route\Router->match
index.php 36 OC::handleRequest
@PVince81
Copy link
Member Author

from a first look we saw that files_sharing/list.php was included 4-5 times and that each time it was firing the LoadSidebar Symfony event which in turn also triggers initialization code of other apps like Talk, which in turn causes some queries to be run multiple times in the context of initial state initialization.

we need to look into why this file is included multiple times, perhaps as a way of including the sharing HTML code multiple times.

maybe we can move those event triggers to ViewController to do them earlier and only once

@PVince81
Copy link
Member Author

PR here: #33548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant