[Bug]: delete.png doesn't exist in core/img/actions/

[miaulalala]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

In apps/settings/lib/Activity/SecurityProvider.php on line 90 and 101 we reference a PNG that does not exist:

server/apps/settings/lib/Activity/SecurityProvider.php

Line 90 in b7bce42

$event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('core', 'actions/delete.png')));

This bug is triggered when the PNG format is enforced for the Activity app emails in MailQueueHandler::sendEmails.

Steps to reproduce

1. Install the activity app
2. Have a case of "remote_wipe_start`or'remote_wipe_finish' to report
3. The sending of the activity email fails because the PNG does not exist.

Expected behavior

The email sends.

Installation method

Manual installation

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

--

Nextcloud Signing status

No response

Nextcloud Logs

{
    "reqId": "TKpiD97xm0eCaMFj0LKO",
    "level": 3,
    "time": "2022-06-02T08:00:03+00:00",
    "remoteAddr": "",
    "user": "--",
    "app": "activity",
    "method": "",
    "url": "--",
    "message": {
        "Exception": "RuntimeException",
        "Message": "image not found: image:actions/delete.png webroot: serverroot:/var/www/nextcloud",
        "Code": 0,
        "Trace": [
            {
                "file": "/var/www/nextcloud/apps/settings/lib/Activity/SecurityProvider.php",
                "line": 91,
                "function": "imagePath",
                "class": "OC\\URLGenerator",
                "type": "->",
                "args": [
                    "core",
                    "actions/delete.png"
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/activity/lib/MailQueueHandler.php",
                "line": 454,
                "function": "parse",
                "class": "OCA\\Settings\\Activity\\SecurityProvider",
                "type": "->",
                "args": [
                    "de",
                    {
                        "__class__": "OC\\Activity\\Event"
                    }
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/activity/lib/MailQueueHandler.php",
                "line": 359,
                "function": "parseEvent",
                "class": "OCA\\Activity\\MailQueueHandler",
                "type": "->",
                "args": [
                    "de",
                    {
                        "__class__": "OC\\Activity\\Event"
                    }
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/activity/lib/MailQueueHandler.php",
                "line": 164,
                "function": "sendEmailToUser",
                "class": "OCA\\Activity\\MailQueueHandler",
                "type": "->",
                "args": [
                    "fjldksjfdslkjflkdsjflkdsjlfkjdskjfkl",
                    "[email protected]",
                    "de",
                    "Europe/Berlin",
                    1654156802
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/activity/lib/BackgroundJob/EmailNotification.php",
                "line": 61,
                "function": "sendEmails",
                "class": "OCA\\Activity\\MailQueueHandler",
                "type": "->",
                "args": [
                    500,
                    1654156802
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/BackgroundJob/Job.php",
                "line": 52,
                "function": "run",
                "class": "OCA\\Activity\\BackgroundJob\\EmailNotification",
                "type": "->",
                "args": [
                    null
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/BackgroundJob/TimedJob.php",
                "line": 59,
                "function": "execute",
                "class": "OC\\BackgroundJob\\Job",
                "type": "->",
                "args": [
                    {
                        "__class__": "OC\\BackgroundJob\\JobList"
                    },
                    {
                        "__class__": "OC\\Log"
                    }
                ]
            },
            {
                "file": "/var/www/nextcloud/cron.php",
                "line": 127,
                "function": "execute",
                "class": "OC\\BackgroundJob\\TimedJob",
                "type": "->",
                "args": [
                    {
                        "__class__": "OC\\BackgroundJob\\JobList"
                    },
                    {
                        "__class__": "OC\\Log"
                    }
                ]
            }
        ],
        "File": "/var/www/nextcloud/lib/private/URLGenerator.php",
        "Line": 238,
        "CustomMessage": "Failed sending activity email to user \"{user}\""
    },
    "userAgent": "--",
    "version": "20.0.14.4"
}

Additional info

No response

[miaulalala]

So we could remove the enforcing of PNG messages from the Activity app. The missing delete.png should still not be referenced in the code though. Looks like this is a technical debt or maybe the image never exited in the first place. At lest it doesn't as far back as Stable20.