Moving shared folders into and out of each other loses share info

[schiessle]

While testing a pull request I observed following behavior on master:

1. user1 shares "folder1" with user2
2. user2 shares his "folder2" with user3
3. user2 moves "folder2" into "folder1"
4. folder2 is still shared with user3 and the "shared from" information changes from user2 to user1 -> perfect!
5. user2 moves "folder2" out of "folder1"
6. "folder2" is no longer shared

First I thought this happens because we do a copy&delete which will result in a new file id because the file gets moved across storages. But then we should already lose the share at step 3. Seems that we have some magic to keep the file id and even change the "owner" if a share gets move into another share but not the other way around.

cc @rullzer @icewind1991

[wiswedel]

I could just reproduce the issue on 16.0.1

[Klakla2]

Reproduced on 16.0.6 .

[Klakla2]

Is there a workaround for this?

[PVince81]

still happening in NC 22.2.0.

[PVince81]

should be fixed already through #30791