Apps can't/aren't removed by occ if appstoreenabled => false

[solracsf]

1. Set 'appstoreenabled' => false,
2. issue app:remove <appname>
3. It outputs it is removed, but it is not, and command can be run on a loop, ex.:

$ php occ app:remove ransomware_protection
ransomware_protection disabled
ransomware_protection 1.10.1 removed

$ php occ app:remove ransomware_protection
ransomware_protection disabled
ransomware_protection 1.10.1 removed

$ php occ app:remove ransomware_protection
ransomware_protection disabled
ransomware_protection 1.10.1 removed
...

4. Set 'appstoreenabled' => true,
5. issue app:remove <appname>
6. App is removed

$ php occ app:remove ransomware_protection
ransomware_protection disabled
ransomware_protection 0 removed

$ php occ app:remove ransomware_protection
ransomware_protection is not installed

While this is the right behaviour to install apps, it should be allowed to remove them even if 'appstoreenabled' => false,

[gary-kim]

This may be the issue. Removing an app relies on OC_App::getInstallPath() which returns false if 'appstoreenabled' => false.

server/lib/private/Installer.php

Line 513 in 56ae87c

$appDir = OC_App::getInstallPath() . '/' . $appId;

server/lib/private/legacy/OC_App.php

Lines 462 to 475 in 784b059

	public static function getInstallPath() {
	if (\OC::$server->getSystemConfig()->getValue('appstoreenabled', true) == false) {
	return false;
	}
	foreach (OC::$APPSROOTS as $dir) {
	if (isset($dir['writable']) && $dir['writable'] === true) {
	return $dir['path'];
	}
	}
	\OCP\Util::writeLog('core', 'No application directories are marked as writable.', ILogger::ERROR);
	return null;
	}

[gary-kim]

I'm working on it :)