Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating public link with an enforced expiration date #25123

Closed
schiessle opened this issue Jan 14, 2021 · 3 comments
Closed

Creating public link with an enforced expiration date #25123

schiessle opened this issue Jan 14, 2021 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: sharing needs info

Comments

@schiessle
Copy link
Member

schiessle commented Jan 14, 2021

When I enforce a expiration date as an admin (Nextcloud 20) and than try to share a file I see this dialog:

image

But how to I proceed? I tried to press enter, nothing happens. I try to open the date picker and tried to pick a date in the hope that this will finish the process with the selected date... nothing happened. I still see:

image

At some point I found out that I just have to click outside of the dialog to close it and accept the input. But that's a really special way to accept the input of a dialog and continue/finish the process.

Can we come up with a more user friendly and better understandable way of to create a share?

Maybe replace the "Cancel" button with an "Accept" button and trigger the cancel operation instead if people click outside of the dialog? I think that would fit better the "I want to escape" thought most people have when they click outside of a dialog.

cc @nextcloud/designers

@schiessle schiessle added bug design Design, UI, UX, etc. feature: sharing 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 14, 2021
@bes1002t
Copy link
Member

bes1002t commented Jan 14, 2021

To be honest, in my Nextcloud 20 installation I don't have a cancel button at this location.

But I agree, the process to share a link is not that intuitive at the moment. Currently if you click on "share" the link is shared automatically. I would suggest to open the share settings dialog, instead of automatically sharing the link. At the bottom of the dialog there should be a "share" button.

So the process would be:

  1. Click on the plus behind "share link"
  2. "share link" settings dialog would appear
  3. configuration if needed
  4. click on the "share" button at the bottom of the dialog

by the way, the datepicker is kind of invisible in a light theme. Maybe it's better to place it somewhere else or use a 2px border to emphasize it in front of the share settings dialog. And it's quite annoying that the datepicker pops up everytime you hover over the datepickers input field. In my humble opinion the datepicker should only appear if you click in that input field.

@szaimen
Copy link
Contributor

szaimen commented Jun 22, 2021

cc @nextcloud/designers for a mockup how this could be improved.

@skjnldsv
Copy link
Member

There's now a dedicated button to create the share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: sharing needs info
Projects
None yet
Development

No branches or pull requests

4 participants