Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing by mail should ignore whitespace #21960

Closed
skjnldsv opened this issue Jul 23, 2020 · 0 comments · Fixed by #21977
Closed

Sharing by mail should ignore whitespace #21960

skjnldsv opened this issue Jul 23, 2020 · 0 comments · Fixed by #21977
Labels
1. to develop Accepted and waiting to be taken care of bug feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 20

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Jul 23, 2020 •
edited
Loading

Unfortunately this doesn't work if the mail address is pasted with preceding or following whitespace(s).
We have users who do that and hit the first result (federated share) which fails, but they very often don't see the error message.

Originally posted by @DanScharon in #16035 (comment)

internal_mail_match_nowhitespace
internal_mail_match_whitespace
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of bug feature: sharing papercut Annoying recurring issue with possibly simple fix. labels Jul 23, 2020
@rullzer rullzer added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jul 23, 2020
@onehappycat onehappycat mentioned this issue Jul 23, 2020
Merged
@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging a pull request may close this issue.

Ignore whitespace in sharing by mail onehappycat/server
3 participants
@rullzer @MorrisJobke @skjnldsv