Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18.0.0 Beta1 - Encryption error (fix included) #18295

Closed
MartB opened this issue Dec 9, 2019 · 2 comments · Fixed by #18300
Closed

18.0.0 Beta1 - Encryption error (fix included) #18295

MartB opened this issue Dec 9, 2019 · 2 comments · Fixed by #18300
Labels
1. to develop Accepted and waiting to be taken care of regression

Comments

@MartB
Copy link
Member

MartB commented Dec 9, 2019

Hey there, i get the following log on the latest beta

TypeError: Argument 3 passed to OCA\Encryption\Recovery::__construct() must be an instance of OCA\Encryption\KeyManager, instance of OC\Security\SecureRandom given, called in /usr/share/nginx/c/apps/encryption/lib/AppInfo/Application.php on line 173

Did i break something or what do i have to do to get rid of this?

Additionally i always get this:
Encryption App is enabled, but your keys are not initialized. Please log-out and log-in again.

@MartB MartB added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 9, 2019
@MartB
Copy link
Member Author

MartB commented Dec 9, 2019

This is caused by the wrong order of constructor arguments here:

return new Recovery(
$server->getUserSession(),
$c->query('Crypt'),
$server->getSecureRandom(),
$c->query('KeyManager'),
$server->getConfig(),
$server->getEncryptionKeyStorage(),
$server->getEncryptionFilesHelper(),
new View());
});

compared to here:

public function __construct(IUserSession $userSession,
Crypt $crypt,
KeyManager $keyManager,
IConfig $config,
IFile $file,
View $view) {

sadly my internet is too bad to clone the repo right now, so yeah feel free to grab an easy fix.

@MartB MartB changed the title 18.0.0 Beta1 - Encryption error 18.0.0 Beta1 - Encryption error (fix included) Dec 9, 2019
@kesselb
Copy link
Contributor

kesselb commented Dec 9, 2019

Regression from #15936

@kesselb kesselb added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 9, 2019
@kesselb kesselb added this to the Nextcloud 18 milestone Dec 9, 2019
@kesselb kesselb added regression and removed bug labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants