Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on accepting share, but nothing happens #17981

Closed
tobiasKaminsky opened this issue Nov 18, 2019 · 4 comments · Fixed by #18222
Closed

Click on accepting share, but nothing happens #17981

tobiasKaminsky opened this issue Nov 18, 2019 · 4 comments · Fixed by #18222

Comments

@tobiasKaminsky
Copy link
Member

mentioned in #16828 (comment), but should be discussed separately:

  • be in files root view
  • receive a share
  • click "accept" on notification
  • nothing happens
    --> where is my file? ;-) I guess this might be irritating users.
    --> can we check if we are in the folder where the shared item should pop up and do a reload?

@nickvergessen @rullzer

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of bug feature: sharing feature: files labels Dec 2, 2019
@nickvergessen
Copy link
Member

Yeah, the notification app emits an event on actions:
https://github.com/nextcloud/notifications/blob/master/src/Components/Action.vue#L51

So the files app should listen to the event and reload when necessary.

@rullzer
Copy link
Member

rullzer commented Dec 4, 2019

Yeah, the notification app emits an event on actions:
https://github.com/nextcloud/notifications/blob/master/src/Components/Action.vue#L51

So the files app should listen to the event and reload when necessary.

@skjnldsv could you look into that?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

So the files app should listen to the event and reload when necessary.

sure!

@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

fix in #18222

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants