Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment (markdown formated) to shared files that is shown when viewed in browser #14746

Closed
small1 opened this issue Mar 19, 2019 · 5 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement

Comments

@small1
Copy link

small1 commented Mar 19, 2019

Description
Add a comment/text (markdown formated?) field to shared links.

When you share a link you can always write what you want to say in a post or an email. But sometimes when you spread a link to a file or folder you might want to add a small text what the doc contains or why it was shared to the recipient(s)

So when you only provide the link it is clear why/what a file/folder is shared.

See attached image

comments_for_shares_concept

@small1 small1 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Mar 19, 2019
@MorrisJobke
Copy link
Member

There is a "set note" feature available for link and email shares. Could you try this? This adds them to the share page as well.

Maybe that's what you are looking for.

@MorrisJobke
Copy link
Member

Bildschirmfoto 2019-03-25 um 10 00 34

@small1
Copy link
Author

small1 commented Mar 25, 2019

That note is a bit invisible for an end user that has zero computer knowledge. And if it is a shared link and not sent by email the end user would not know that it is there.

My proposal is that it should be shown together with the preview somewhere. Down with the download link perhaps. Or at least a bit more visible.

@MorrisJobke
Copy link
Member

My proposal is that it should be shown together with the preview somewhere. Down with the download link perhaps. Or at least a bit more visible.

This was decided like that by the designers team @nextcloud/designers.

In the future there is also the sidebar planned to be added to this view and there you can embed the comments for better visibility. See #10931 - it's planned for 17 and might help with your situation.

@jancborchardt
Copy link
Member

Yep, the note should go into the sidebar, just like future commenting ability for guests etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
None yet
Development

No branches or pull requests

3 participants