Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After organizer moves event, attendee status is still "accepted", should be "needs-action" #13862

Open
igorr-stc opened this issue Jan 28, 2019 · 11 comments · May be fixed by #47308
Open

After organizer moves event, attendee status is still "accepted", should be "needs-action" #13862

igorr-stc opened this issue Jan 28, 2019 · 11 comments · May be fixed by #47308

Comments

@igorr-stc
Copy link

Steps to reproduce

  1. Organizer creates an event, adds attendees to the event
  2. Attendee accepts event (PARTSTAT=ACCEPTED)
  3. Organizer moves event to different time
  4. In attendees calendar event is moved too but is still accepted by attendee

Expected behaviour

Attendee status should change to "needs-action" (PARTSTAT=NEEDS-ACTION), because attendee may be not very happy about time change.
And if he gets a lot of calendar emails he can just miss notification.

Actual behaviour

Event is moved in other participants calendars and their status is not changed (still ACCEPTED or DECLINED)

Server configuration

Nextcloud version:
14.0.3

Where did you install Nextcloud from:

Signing status:

Signing status
No errors have been found.

List of activated apps:

App list
Enabled:
  - accessibility: 1.0.1
  - activity: 2.7.0
  - calendar: 1.6.3
  - cloud_federation_api: 0.0.1
  - comments: 1.4.0
  - contacts: 2.1.7
  - dav: 1.6.0
  - federatedfilesharing: 1.4.0
  - federation: 1.4.0
  - files: 1.9.0
  - files_accesscontrol: 1.4.0
  - files_markdown: 2.0.5
  - files_pdfviewer: 1.3.2
  - files_sharing: 1.6.2
  - files_texteditor: 2.6.0
  - files_trashbin: 1.4.1
  - files_versions: 1.7.1
  - files_videoplayer: 1.3.0
  - impersonate: 1.1.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.2.0
  - mail: 0.11.0
  - nextcloud_announcements: 1.3.0
  - notes: 2.5.0
  - notifications: 2.2.1
  - oauth2: 1.2.1
  - password_policy: 1.4.0
  - provisioning_api: 1.4.0
  - richdocuments: 3.0.5
  - serverinfo: 1.4.0
  - sharebymail: 1.4.0
  - support: 1.0.0
  - systemtags: 1.4.0
  - tasks: 0.9.7
  - theming: 1.5.0
  - twofactor_backupcodes: 1.3.1
  - user_ldap: 1.4.0
  - workflowengine: 1.4.0
Disabled:
  - admin_audit
  - encryption
  - files_external
  - firstrunwizard
  - gallery
  - spreed
  - survey_client
  - updatenotification
  - user_external

Nextcloud configuration:

Config report
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "version": "14.0.3.0",
        "dbtype": "mysql",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "installed": true,
        "default_language": "ru",
        "defaultapp": "files",
        "knowledgebaseenabled": false,
        "allow_user_to_change_display_name": false,
        "remember_login_cookie_lifetime": 1296000,
        "session_lifetime": 86400,
        "session_keepalive": true,
        "token_auth_enforced": false,
        "auth.bruteforce.protection.enabled": true,
        "lost_password_link": "disabled",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpdebug": false,
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "mail_smtptimeout": 10,
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "htaccess.IgnoreFrontController": true,
        "proxy": "",
        "proxyuserpwd": "***REMOVED SENSITIVE VALUE***",
        "trashbin_retention_obligation": "auto",
        "versions_retention_obligation": "auto",
        "appcodechecker": true,
        "updatechecker": false,
        "updater.server.url": "https:\/\/updates.nextcloud.com\/updater_server\/",
        "updater.release.channel": "stable",
        "has_internet_connection": true,
        "check_for_working_webdav": true,
        "check_for_working_wellknown_setup": true,
        "check_for_working_htaccess": true,
        "check_data_directory_permissions": true,
        "config_is_read_only": false,
        "log_type": "syslog",
        "logfile": "",
        "loglevel": 2,
        "syslog_tag": "nextcloud",
        "logdateformat": "F d, Y H:i:s",
        "logtimezone": "Europe\/Moscow",
        "log_query": false,
        "log_rotate_size": false,
        "customclient_desktop": "https:\/\/nextcloud.com\/install\/#install-clients",
        "customclient_android": "https:\/\/play.google.com\/store\/apps\/details?id=com.nextcloud.client",
        "customclient_ios": "https:\/\/itunes.apple.com\/us\/app\/nextcloud\/id1125420102?mt=8",
        "appstoreenabled": true,
        "apps_paths": [
            {
                "path": "\/usr\/local\/www\/nextcloud\/apps",
                "url": "\/apps",
                "writable": true
            },
            {
                "path": "\/usr\/local\/www\/nextcloud\/apps-pkg",
                "url": "\/apps-pkg",
                "writable": false
            }
        ],
        "enable_previews": true,
        "preview_max_x": 4096,
        "preview_max_y": 4096,
        "preview_max_filesize_image": 50,
        "preview_libreoffice_path": "",
        "preview_office_cl_parameters": " --headless --nologo --nofirststartwizard --invisible --norestore --convert-to pdf --outdir ",
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown"
        ],
        "ldapUserCleanupInterval": 51,
        "sort_groups_by_name": false,
        "comments.managerFactory": "\\OC\\Comments\\ManagerFactory",
        "systemtags.managerFactory": "\\OC\\SystemTag\\ManagerFactory",
        "mail_template_class": "\\OC\\Mail\\EMailTemplate",
        "maintenance": false,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 1.5
        },
        "cache_path": "",
        "cache_chunk_gc_ttl": 86400,
        "mysql.utf8mb4": false,
        "tempdirectory": "\/data\/tmp",
        "hashingCost": 10,
        "blacklisted_files": [
            ".htaccess"
        ],
        "share_folder": "\/",
        "theme": "",
        "cipher": "AES-256-CFB",
        "minimum.supported.desktop.version": "2.0.0",
        "quota_include_external_storage": false,
        "filesystem_check_changes": 0,
        "part_file_in_storage": true,
        "mount_file": "\/usr\/local\/www\/nextcloud\/data\/mount.json",
        "filesystem_cache_readonly": false,
        "secret": "***REMOVED SENSITIVE VALUE***",
        "max_filesize_animated_gifs_public_sharing": 5,
        "filelocking.enabled": true,
        "filelocking.ttl": 3600,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "filelocking.debug": false,
        "upgrade.disable-web": true,
        "debug": false,
        "data-fingerprint": "",
        "gs.enabled": false,
        "gs.federation": "internal",
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory"
    }
}

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: yes/no
no

@igorr-stc igorr-stc added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 28, 2019
@skjnldsv
Copy link
Member

Pinging Dr @georgehrke 🔎

@ghost ghost added the stale Ticket or PR with no recent activity label May 10, 2020
@Nils160988 Nils160988 removed the stale Ticket or PR with no recent activity label May 11, 2020
@ghost ghost added the stale Ticket or PR with no recent activity label Jun 10, 2020
@Nils160988
Copy link
Contributor

Not sure if this is still valid
@igorr-stc?
Or do you have any new information @georgehrke?

@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 10, 2020
@ghost ghost added the stale Ticket or PR with no recent activity label Jul 10, 2020
@skjnldsv
Copy link
Member

@Nils160988 I guess @georgehrke is pretty busy :(

@ghost ghost removed the stale Ticket or PR with no recent activity label Jul 14, 2020
@georgehrke
Copy link
Member

Valid issue

Spec: https://tools.ietf.org/html/rfc6638#section-3.2.8

A reschedule occurs when any "DTSTART", "DTEND", "DURATION", "DUE",
"RRULE", "RDATE", or "EXDATE" property changes in a calendar
component such that existing recurrence instances are impacted by the
changes, as shown in the table below. Servers MUST reset the
"PARTSTAT" property parameter value of all "ATTENDEE" properties,
except the one that corresponds to the "Organizer", to "NEEDS-ACTION"
for each calendar component change that causes any instance to be
rescheduled.

Needs to be reported upstream in Sabre/DAV (/ Sabre/VObject )

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of feature: dav and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jul 14, 2020
@georgehrke
Copy link
Member

I created an upstream issue: sabre-io/dav#1282
I have to see if i will find time to send a patch.

@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@tobiasKaminsky
Copy link
Member

No one worked on this, tested and still happens.

@onny
Copy link

onny commented Feb 23, 2023

@georgehrke Shouldn't PARTSTAT set to NEEDS-ACTION by the calendar app?
If I update the start time of an event following CalDav data gets submitted to the Nextcloud backend

BEGIN:VCALENDAR
CALSCALE:GREGORIAN
VERSION:2.0
PRODID:-//IDN nextcloud.com//Calendar app 4.2.1//EN
BEGIN:VEVENT
CREATED:20230223T182815Z
DTSTAMP:20230223T183600Z
LAST-MODIFIED:20230223T183600Z
SEQUENCE:4
UID:fe50b6ec-8933-4f8f-976b-542958efb601
DTSTART;VALUE=DATE:20230226
DTEND;VALUE=DATE:20230227
STATUS:CONFIRMED
SUMMARY:test neu 2
ATTENDEE;CN=user1;CUTYPE=INDIVIDUAL;PARTSTAT=ACCEPTED;ROLE=REQ-PARTICIPANT;
 LANGUAGE=en;SCHEDULE-STATUS=2.0:mailto:user1@localhost
ORGANIZER;CN=admin:mailto:admin@localhost
END:VEVENT
END:VCALENDAR

Shouldn't we already set PARTSTAT=NEEDS-ACTION for every attendee here? Or is this something which should be managed by nextcloud/apps/dav or sabre-io/dav backend?

@SebastianKrupinski
Copy link
Contributor

Already resolved with above pull request

@github-project-automation github-project-automation bot moved this from 📄 To do to ☑️ Done in 💌 📅 👥 Groupware team Jul 1, 2024
@tobiasKaminsky
Copy link
Member

Reading the PR it seems that it only reset when using NC Calendar, but not when using e.g. Thunderbird to move an event?

@tobiasKaminsky tobiasKaminsky reopened this Jul 3, 2024
@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do in 💌 📅 👥 Groupware team Jul 3, 2024
@SebastianKrupinski SebastianKrupinski self-assigned this Jul 3, 2024
@SebastianKrupinski
Copy link
Contributor

@tobiasKaminsky confirmed. The issues still exists in TB.

@SebastianKrupinski SebastianKrupinski added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging a pull request may close this issue.

10 participants