Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortlink to files should be automatically copied when user clicks on the button #1273

Closed
oparoz opened this issue Sep 5, 2016 · 7 comments
Labels
design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.

Comments

@oparoz
Copy link
Member

oparoz commented Sep 5, 2016

Steps to reproduce

  1. Activate the sidebar for a file
  2. Click on the anchor (next to the title on the right)

Expected behaviour

The link is shown and is highlighted. It should be copied in memory so that I can paste it right away

Actual behaviour

The link has not been copied, despite the fact that it's highlighted. This is misleading.


@jancborchardt

@oparoz oparoz added bug design Design, UI, UX, etc. labels Sep 5, 2016
@rullzer
Copy link
Member

rullzer commented Sep 5, 2016

On the one hand I get it. on the other hand I still feel very uncomfortable with automagically overwriting the clipboard. Same when creating a share link.

@oparoz
Copy link
Member Author

oparoz commented Sep 5, 2016

I agree, but then we shouldn't highlight that link. Let's do it when the user clicks/taps on it.

@rullzer
Copy link
Member

rullzer commented Sep 5, 2016

I think it would be good to just add the clipboard thingy then. Like we have with the sharedlink. To the right of it. That is a real action (with tooltip copy to clipboard).

@oparoz
Copy link
Member Author

oparoz commented Sep 5, 2016

Agreed

@jancborchardt
Copy link
Member

Let's not keep adding more and more things. Simpler solution:

  • The link icon should be a clipboard icon instead
  • Tooltip: Copy local link
  • Should copy link to clipboard on click (with confirmation »Copied to clipboard« via tooltip)
  • No link box needed

@rullzer
Copy link
Member

rullzer commented Sep 13, 2016

@jancborchardt that is not really true. For example not all OS X thingies support the clipboard.

@MorrisJobke MorrisJobke added papercut Annoying recurring issue with possibly simple fix. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed bug labels Aug 31, 2017
@rullzer
Copy link
Member

rullzer commented Aug 31, 2017

Already fixed in master

@rullzer rullzer closed this as completed Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

4 participants