Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature Panel #1213

Closed
9 tasks
blizzz opened this issue Aug 31, 2016 · 6 comments
Closed
9 tasks

Signature Panel #1213

blizzz opened this issue Aug 31, 2016 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing spec

Comments

@blizzz
Copy link
Member

blizzz commented Aug 31, 2016

Signature panel

The Signature panel allows users of a file to mark it as accepted/rejected. This is useful and targeted for auditing purposes. File owners/Sharer sees the state of each sharee.

Requirements

  • add signature check box to sharing dialog (per sharee).
  • notification are sent out with signature box ticking. Notification should bring you to the file, signature tab.
    shares with signature enabled have signature tab in sidebar
  • support remote shares
  • Sharer sees full list of sharees and their state (Received, Accepted, Rejected). Groups expandable.
  • Sharee sees only its state and action buttons/slider: (Received/Neutral,) Accepted, Rejected (undoable)
  • Reset state on file update
  • Show done action in activity feed
  • Keep Signatures for old file versions, depending on versions_app enabled. Save the file version internally (e.g. within the object id by using comments infrastructure, or as json in message body). Clean up after deleted file versions.

Nice to have

  • Tweak the version tab to show signature state

Feedback appreciated @oparoz @jancborchardt @nickvergessen @schiessle

@blizzz blizzz added enhancement 1. to develop Accepted and waiting to be taken care of spec labels Aug 31, 2016
@blizzz blizzz added this to the Nextcloud 11.0 milestone Aug 31, 2016
@MorrisJobke MorrisJobke mentioned this issue Aug 31, 2016
47 tasks
@blizzz
Copy link
Member Author

blizzz commented Sep 20, 2016

Discussion with @schiessle @jancborchardt @oparoz and me at Nextcloud conf:

  • no extra tab, integrate with Sharing and add as Sharing option in Sharing app
  • requires Move sharing options into popover menu #607, option to add per sharee in the 3-dot-menu
  • requires 3-dot-menu in Details Sidebar (integrate local links, tags¹), precondition
  • add drop-down to 3-dot-menu (approve, undecided, reject)
  • add icon indicator to file row (like for new comments)

¹tags input field not shown when no tags are assigned, otherwise it stays like it is currently

cc @nickvergessen (fyi, 3-dot-menu in details sidebar)

@jospoortvliet
Copy link
Member

@jancborchardt any chance you can do a mockup 💃

@MorrisJobke
Copy link
Member

@blizzz @karlitschek I guess it's not feasible within the scope of 12 -> moved to 13

@karlitschek
Copy link
Member

ok

@MorrisJobke MorrisJobke removed this from the Nextcloud 13 milestone Nov 13, 2017
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@skjnldsv skjnldsv removed stale Ticket or PR with no recent activity labels Jun 12, 2019
@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I'm closing this issue due to inactivity. Please reopen if you still want to implement this.

@szaimen szaimen closed this as completed May 21, 2021
@nickvergessen
Copy link
Member

Similar replacement could be https://github.com/eneiluj/approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing spec
Projects
None yet
Development

No branches or pull requests

8 participants