Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dav endpoint: add share note #11702

Closed
tobiasKaminsky opened this issue Oct 9, 2018 · 6 comments
Closed

Dav endpoint: add share note #11702

tobiasKaminsky opened this issue Oct 9, 2018 · 6 comments

Comments

@tobiasKaminsky
Copy link
Member

In current file listing (http://localhost/nc/remote.php/webdav/$folder), we do not get the note of a share, which any user can set when creating a share.

So it would be nice, to have a new property to get this directly.
Otherwise all clients would have to do another call to server to get this info.

As discussed with @schiessle.

Maybe @rullzer @blizzz have a little spare time, to get this in for NC15 ❤️

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #3801 (Adding appointment into shared calendar fails), #10218 (allow to add a personal note to a share), #10834 (Add support for room shares), #10255 (Add support for room shares), and #7242 (New shares should be added at the top of the list).

@blizzz
Copy link
Member

blizzz commented Oct 12, 2018

Maybe @rullzer @blizzz have a little spare time, to get this in for NC15 heart

sorry, already having troubles to get my planned stuff in

@tobiasKaminsky
Copy link
Member Author

Can we get this into NC16? @rullzer @blizzz? ❤️

@blizzz blizzz added this to the Nextcloud 16 milestone Dec 6, 2018
@blizzz
Copy link
Member

blizzz commented Dec 6, 2018

@tobiasKaminsky this is supposded to be read only, I guess?

@tobiasKaminsky
Copy link
Member Author

Yes. For setting a note we already have an endpoint in share api.

I already tried to start yesterday evening. I can give you my branch.

@tobiasKaminsky
Copy link
Member Author

@blizzz I created a PR #12978 if you wanna have a look :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants