Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the "share by direct link" option for files that in usually under the "share by email" is gone #11450

Closed
lordhippo93 opened this issue Sep 29, 2018 · 8 comments
Labels
1. to develop Accepted and waiting to be taken care of bug needs info

Comments

@lordhippo93
Copy link

Steps to reproduce

  1. upgrade from 13 to 14
  2. now it is just gone for me.

Expected behaviour

seeing the interface for and, being able to get link to send to friends

Actual behaviour

the whole option is gone. i can see the that there are old share links active, but i can unshare them because the interface is gone.

Server configuration

Operating system:
Ubuntu 16:04

Web server:
default, being proxid in throge a caddy server for the https.

Database:
default

PHP version:
default

Nextcloud version: (see Nextcloud admin page)
Nextcloud 14.0.1

Updated from an older Nextcloud/ownCloud or fresh install:
from an older nextcloud

Where did you install Nextcloud from:
your update app

Signing status:

Signing status
Login as admin user into your Nextcloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results here.

List of activated apps:

App list
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

Config report
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

root@nextcloud:/var/www/nextcloud# sudo -u www-data php occ config:list system
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "192.168.1.112",
            "next.windwaker.se"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/next.windwaker.se",
        "dbtype": "mysql",
        "version": "14.0.1.1",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "htaccess.RewriteBase": "\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_smtpmode": "sendmail",
        "mail_smtpauthtype": "LOGIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "updater.release.channel": "stable",
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}



or 

Insert your config.php content here. 
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using external storage, if yes which one: local/smb/sftp/...
local

Are you using encryption: yes/no
no i dont think so

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no i dont think so

With access to your command line run e.g.:
sudo -u www-data php occ ldap:show-config
from within your Nextcloud installation folder

"root@nextcloud:/var/www/nextcloud# sudo -u www-data php occ ldap:show-config


  There are no commands defined in the "ldap" namespace.

"

Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remotely and run the select query:
SELECT * FROM `oc_appconfig` WHERE `appid` = 'user_ldap';


Eventually replace sensitive data as the name/IP-address of your LDAP server or groups.

Client configuration

Browser:

Operating system:

Logs

Web server error log

Web server error log
Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Nextcloud log
Insert your Nextcloud log here

Browser log

Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #2357 (Sharing a file via email and password protect the link), #7469 (Cannot set password for share by email links), #5537 ("shared by link" doesn't show folder or files shared via email.), #9170 (redirect), and #8241 (image).

@MorrisJobke
Copy link
Member

the whole option is gone. i can see the that there are old share links active, but i can unshare them because the interface is gone.

The link shares are still there, but look a bit different:

bildschirmfoto 2018-09-30 um 12 02 59

Clicking the enable will give you the link again. Unsharing works the same way it did before: just untick the checkbox again.

Does that help you?

cc @jancborchardt

@lordhippo93
Copy link
Author

that did not help.
there is somthing missing for me

skarmklipp

skarmklipp2

@lordhippo93
Copy link
Author

huh.................. that i did not expect....! the option is there, but get caught up ublock origens cosmetic filter. that was a new one for me :)

skarmklipp3

i have ublock origens in both chrome and firefox, and it fails so rarly it dident cross my mind until your picture :)

@MorrisJobke
Copy link
Member

I also had another person complaining about the missing option which also resulted in the ad blocker being the cause.

We will have a look and maybe update the identifiers.

@3L1AS
Copy link

3L1AS commented Oct 2, 2018

Same issue with AdGuard. For some reason, this was totally missing: https://i.imgur.com/6kjRkv4.png

@jancborchardt jancborchardt added bug needs info 1. to develop Accepted and waiting to be taken care of labels Oct 2, 2018
@jancborchardt jancborchardt reopened this Oct 2, 2018
@jancborchardt
Copy link
Member

So we have 2 solutions here:

  1. We fix it at all the Adblockers → they will likely have more rules in the future and we need to adjust
  2. We fix it in our software → this will likely mean not using the word "share" anywhere … totally stupid rule from the adblockers. Also, they might even block the word we decide to use.

Any ideas?

@jancborchardt
Copy link
Member

Duplicate of #10434 – let’s continue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug needs info
Projects
None yet
Development

No branches or pull requests

5 participants