From d2b31d67f16f38b5c9554a2a7d61350d2f10c97d Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Wed, 20 May 2020 15:54:16 +0200 Subject: [PATCH] update saved credentials on password change Signed-off-by: Robin Appelman --- .../Lib/Auth/Password/LoginCredentials.php | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php b/apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php index b8dace8bf5336..5ea4a698208e9 100644 --- a/apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php +++ b/apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php @@ -29,10 +29,13 @@ use OCA\Files_External\Lib\StorageConfig; use OCP\Authentication\Exceptions\CredentialsUnavailableException; use OCP\Authentication\LoginCredentials\IStore as CredentialsStore; +use OCP\EventDispatcher\IEventDispatcher; use OCP\IL10N; use OCP\ISession; use OCP\IUser; use OCP\Security\ICredentialsManager; +use OCP\User\Events\PasswordUpdatedEvent; +use OCP\User\Events\UserLoggedInEvent; /** * Username and password from login credentials, saved in DB @@ -49,7 +52,7 @@ class LoginCredentials extends AuthMechanism { /** @var CredentialsStore */ private $credentialsStore; - public function __construct(IL10N $l, ISession $session, ICredentialsManager $credentialsManager, CredentialsStore $credentialsStore) { + public function __construct(IL10N $l, ISession $session, ICredentialsManager $credentialsManager, CredentialsStore $credentialsStore, IEventDispatcher $eventDispatcher) { $this->session = $session; $this->credentialsManager = $credentialsManager; $this->credentialsStore = $credentialsStore; @@ -60,6 +63,29 @@ public function __construct(IL10N $l, ISession $session, ICredentialsManager $cr ->setText($l->t('Log-in credentials, save in database')) ->addParameters([ ]); + + $eventDispatcher->addListener(UserLoggedInEvent::class, [$this, 'updateCredentials']); + $eventDispatcher->addListener(PasswordUpdatedEvent::class, [$this, 'updateCredentials']); + } + + /** + * @param UserLoggedInEvent | PasswordUpdatedEvent $event + */ + public function updateCredentials($event) { + if ($event instanceof UserLoggedInEvent && $event->isTokenLogin()) { + return; + } + + $stored = $this->credentialsManager->retrieve($event->getUser()->getUID(), self::CREDENTIALS_IDENTIFIER); + + if ($stored && $stored['password'] != $event->getPassword()) { + $credentials = [ + 'user' => $stored['user'], + 'password' => $event->getPassword() + ]; + + $this->credentialsManager->store($event->getUser()->getUID(), self::CREDENTIALS_IDENTIFIER, $credentials); + } } private function getCredentials(IUser $user): array {