Design regressions of "Recommended files" widget

[jancborchardt]

There are some regressions to the recommended Files widget as seen below:

• Filetypes without preview are shown as if they are avatar placeholders, not with their proper mimetype icon
• Folders are put in a circle, not just shown as icon
• Similar for previews, they are circled, but should be a square with rounded corners like in the Files app
• File names are aligned to the top, but should be vertically centered with the filetype icon / preview as before
• File extensions are shown same color as filename, but should be color-text-maxcontrast as we do in Files

Intended	Current Nextcloud

[jancborchardt]

@szaimen @marcoambrosini could one of you pick this up to fix this, maybe even for 29? It’s a regression which makes the Dashboard look a bit unpolished.

[susnux]

@jancborchardt the dashboard widget looks exactly like all others - if you prefer the less rounded one then we need to change it also for all others (e.g. the "statuses" dashboard).

[susnux]

Like the general dashboard widget styles are that rounded - same as the login box.

Unrelated but we should probably either use the drop shadow for all of these components or for none for consistency (there is shadow for the login box but not for dashboard widgets), no?

[jancborchardt]

@jancborchardt the dashboard widget looks exactly like all others - if you prefer the less rounded one then we need to change it also for all others (e.g. the "statuses" dashboard).

@susnux sorry the screenshot is a bit confusing – I am not talking about the bigger border-radius of the outside container, that is of course fine. :) I mean that the filetype icons themselves are in a rounded container, being cut off.

[susnux]

Ah yes I see, the avatar component should probably not used here, it makes not much sense.

[emoral435]

This seems interesting. I have time right now to pick this up, so will be working on this 👍

[emoral435]

Really weird finding --- on my mac, the recommendations widget seems to be pulling directly from the recommendations app itself, and shows that there is no regression to be found - everything is styled correctly:

However, on my windows, it seems like the dashboard widget is using our default NcWidget component, and other default dashboard components. Will try to debug this, but it is a bit weird 😕

[jancborchardt]

This was all fixed by now.