Slideshow photos for public links #128

schaze · 2020-01-18T16:57:06Z

With Nextcloud 18 and Photos app there is no preview popup any more for pictures in folder share by link. When clicking a picture, always the download function is triggered. With this there is basically no real image gallery sharing possible any more.
In Nextcloud 17 with the gallery app there was a preview popup and a slideshow option also for shared folders.

Please bring that back. I love how fast the new photos app is (order of magnitude faster than in nc17) but image preview is a basic funtction I really cannot miss (or rather the rest of my family wanting to see the images of my daughter)

Server configuration detail

Operating system: Linux 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64

Webserver: Apache/2.4.38 (Debian) (apache2handler)

Database: mysql 10.4.11

PHP version: 7.3.13

Modules loaded: Core, date, libxml, openssl, pcre, sqlite3, zlib, ctype, curl, dom, fileinfo, filter, ftp, hash, iconv, json, mbstring, SPL, PDO, session, posix, Reflection, standard, SimpleXML, pdo_sqlite, Phar, tokenizer, xml, xmlreader, xmlwriter, mysqlnd, apache2handler, apcu, exif, gd, gmp, imagick, intl, ldap, memcached, pcntl, pdo_mysql, pdo_pgsql, redis, sodium, zip, Zend OPcache

Nextcloud version: 18.0.0 - 18.0.0.10

Updated from an older Nextcloud/ownCloud or fresh install: updated from 17.0

Where did you install Nextcloud from: Docker deployed on kubernetes 1.17.0

Signing status

Array ( )

List of activated apps

Enabled:

accessibility: 1.4.0
calendar: 2.0.0
carnet: 0.19.2
cloud_federation_api: 1.1.0
cms_pico: 1.0.4
comments: 1.8.0
dav: 1.14.0
encryption: 2.6.0
external: 3.5.0
federatedfilesharing: 1.8.0
federation: 1.8.0
files: 1.13.1
files_external: 1.9.0
files_pdfviewer: 1.7.0
files_sharing: 1.10.1
files_trashbin: 1.8.0
files_versions: 1.11.0
files_videoplayer: 1.7.0
firstrunwizard: 2.7.0
logreader: 2.3.0
lookup_server_connector: 1.6.0
nextcloud_announcements: 1.7.0
notifications: 2.6.0
oauth2: 1.6.0
onlyoffice: 4.1.1
password_policy: 1.8.0
photos: 1.0.0
previewgenerator: 2.2.0
privacy: 1.2.0
provisioning_api: 1.8.0
recommendations: 0.6.0
serverinfo: 1.8.0
settings: 1.0.0
sharebymail: 1.8.0
support: 1.1.0
survey_client: 1.6.0
systemtags: 1.8.0
tasks: 0.11.3
text: 1.0.2
theming: 1.9.0
twofactor_backupcodes: 1.7.0
updatenotification: 1.8.0
viewer: 1.2.0
workflowengine: 2.0.0
Disabled:
activity
admin_audit
bruteforcesettings
contacts
files_rightclick
user_ldap

Configuration (config/config.php)

{
"htaccess.RewriteBase": "/",
"apps_paths": [
{
"path": "/var/www/html/apps",
"url": "/apps",
"writable": false
},
{
"path": "/var/www/html/custom_apps",
"url": "/custom_apps",
"writable": true
}
],
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"*REMOVED SENSITIVE VALUE",
"nextcloud"
],
"trusted_proxies": "REMOVED SENSITIVE VALUE",
"forwarded_for_headers": [
"X-Forwarded-For",
"HTTP_X_FORWARDED_FOR"
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "18.0.0.10",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbport": "3306",
"dbtableprefix": "oc_",
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"installed": true,
"theme": "",
"loglevel": 2,
"maintenance": false,
"mail_smtpmode": "smtp",
"mail_smtpauthtype": "PLAIN",
"mail_smtpsecure": "ssl",
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_domain": "REMOVED SENSITIVE VALUE",
"mail_smtpauth": 1,
"mail_smtphost": "REMOVED SENSITIVE VALUE",
"mail_smtpport": "465",
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE",
"preview_max_x": 1024,
"preview_max_y": 768,
"preview_max_scale_factor": 1,
"memcache.local": "\OC\Memcache\APCu",
"memcache.locking": "\OC\Memcache\Redis",
"redis": {
"host": "REMOVED SENSITIVE VALUE",
"port": 6379
},
"overwrite.cli.url": "https://*REMOVED SENSITIVE VALUE",
"overwriteprotocol": "https",
"mysql.utf8mb4": false,
"app_install_overwrite": [
"text"
],
"has_rebuilt_cache": true
}

External storages: yes

External storage configuration

No mounts configured

Encryption: no

User-backends:

OC\User\Database

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36

skjnldsv · 2020-01-18T18:47:22Z

Hello!
I'm not sure I understand, what do you mean by a preview popup? You mean opening the slideshow view on click?
Or you mean having the photo layout on 'public' pages?

schaze · 2020-01-18T20:04:19Z

Hi,
sorry for beeing unclear.
I do get thumbnails in the shared folder but not the slideshow view. If what you mean with slideshow view is this the one looking like this:

Instead I get this for the shared folder when accessing it via the share link:

skjnldsv · 2020-01-19T15:12:35Z

Instead I get this for the shared folder when accessing it via the share link:

Ah, ok!
Yes, photos is not handling public links yet :)

menaceone · 2020-02-01T19:42:11Z

Hey folks,
I really miss that feature as well. If any help for testing etc. is needed just ping me.
greetings

Sandman0984 · 2020-02-04T17:55:01Z

Hi,
I would like to see this feature added to Photos as well! Just like @menaceone , I'll help with testing if you need it. Keep up the good work! Thank you!

grenzverkehr · 2020-02-09T17:32:25Z

This problem has nothing to do with "Photo" but with the fact that the "gallery slideshow" no longer exists (nextcloud/viewer#89 (comment)). If the problem is indeed only solved with the release of version 19, version 18 will remain useless for many people.

hroling · 2020-02-13T20:10:14Z

This is really a big disappointment that the slideshow is not working in NC18 and the Photo app. I will skip NC18 and wait for NC19. I will downgrade to NC17 and restore my backup.

This is the first time i'm not glad with the new version since owncloud 5.

hroling · 2020-03-23T14:06:00Z

If I share a directory with photo's I don't see it in the shared albums. Is that correct?

skjnldsv · 2020-03-23T14:10:03Z

No, it's photos that are shared with you

hroling · 2020-03-23T14:58:13Z

No, it's photos that are shared with you

Thanks. That was nog really clear.... :)

ainola · 2020-03-24T03:51:53Z

Hm, I'm still getting downloads with 18.0.3 and a public share link. Should I be doing anything other than merely updating?

skjnldsv · 2020-03-24T07:45:15Z

Yep, sorry, 18.0.3 is an unexpected security update.
18.0.4 it is :)

jhesketh · 2020-03-24T09:07:45Z

Just a note for those following along, I was experiencing another bug due to my federation configuration: nextcloud/server#20132

menaceone · 2020-03-24T09:24:09Z

Yep, sorry, 18.0.3 is an unexpected security update.
18.0.4 it is :)

Hey,
is there any (roughly) estimated release date for 18.0.4 or is it "done when it's done"?

adsworth · 2020-03-24T09:26:59Z

Hey,
is there any (roughly) estimated release date for 18.0.4 or is it "done when it's done"?

Apparently 23rd of April is the planned date.

https://github.com/nextcloud/server/milestone/115

BotoX · 2020-03-24T14:44:35Z

First it's been 18.0.2, then 18.0.3 and now 18.0.4 which could take another month+
Can I just upgrade the photos plugin on my nextcloud install and skip yet another month of all my albums being down?

I really appreciate the work you guys put into this project, I've got a few smaller ones of my own and know how hard it can be to deal with lots of user inquiries in your free time.
But the way this has been handled so far is a really big turnoff for nextcloud.
At least present some kind of fix for affected people, since the code has seemingly already been written but not included in the release?
Thank you.

P.S. should this issue really be closed when it's not fixed in nextcloud yet?

skjnldsv · 2020-03-24T14:47:04Z

P.S. should this issue really be closed when it's not fixed in nextcloud yet?

fixed and released are two different things :)

skjnldsv · 2020-03-24T14:51:22Z

At least present some kind of fix for affected people, since the code has seemingly already been written but not included in the release?

Feel free to patch it yourself from the viewer/server code.
The pull requests have been linked in this issues and the associated ones.

But the way this has been handled so far is a really big turnoff for nextcloud.

We don't aim for weird patches and quick releases unless those touches security. Stability is the most important thing. If you want to skip the beta and rc tests phases to have your own instance up and running, feel free to do so. But This is a project that aims to be serious and professional and we cannot afford to risk things for the sake of having users not wait 1 month for a fix.

hroling · 2020-03-24T15:06:59Z

Is it possible to use the new app in NC 18.0.3? And, if yes, how?

Leon5x · 2020-03-29T21:01:14Z

A workaround until NC 18.0.4 is released is described here:
https://help.nextcloud.com/t/new-photo-app-in-nextcloud-18/69949/20
You can enable the old gallery app under NC 18. But this app does only work on public shares without a password when you use the sharing link like before (url.com/apps/gallery/s/awhdkawhd).
Btw, thanks for fixing everything for the next release properly!

jean-io · 2020-03-30T08:25:36Z

Yep, sorry, 18.0.3 is an unexpected security update.
18.0.4 it is :)

Why do you need to wait for a server upgrade if you can publish an new release of just the app?
Whats the goal of having a separate app if development and releases are bind to server?
🤔

Anyway thank for this great open source project 🥇

skjnldsv · 2020-03-30T08:27:16Z

Whats the goal of having a separate app if development and release is bind to server release?

This is not a separate app, this is a separate repository.
This app is shipped with server releases :)

Chillstice · 2020-04-23T19:54:24Z

18.0.4 finally came out today and I was excited to update and check out if this works again. Turns out, not really.

The functionality appears to be returned - clicking an image from a gallery/ folder via shared link displays a lightbox - but the image never loads. It just indefinitely shows the loading animation.

I'm trying this with already existing shared-folders and I haven't tested extensively, but so far it doesn't appear to be working as intended.

NOTNlCE · 2020-04-23T19:56:52Z

The functionality appears to be returned - clicking an image from a gallery/ folder via shared link displays a lightbox - but the image never loads. It just indefinitely shows the loading animation.

I updated this morning and am NOT experiencing the above issue. Mine seems to work as intended, but I shared my albums fresh this morning.

mwllgr · 2020-04-23T19:58:14Z

It works for me too. And I shared the album around three months ago.

Chillstice · 2020-04-23T20:00:53Z

I just checked the console in a fresh chrome browser and I'm getting what appears to be a permission issue?
https://s.chillstice.com/ajHke

szaimen · 2020-04-23T20:01:19Z

18.0.4 finally came out today and I was excited to update and check out if this works again. Turns out, not really.

The functionality appears to be returned - clicking an image from a gallery/ folder via shared link displays a lightbox - but the image never loads. It just indefinitely shows the loading animation.

I'm trying this with already existing shared-folders and I haven't tested extensively, but so far it doesn't appear to be working as intended.

I just checked the console in a fresh chrome browser and I'm getting what appears to be a permission issue?
https://s.chillstice.com/ajHke

I have the same problem. But it also doesn't work with new shares.

I am using external storage. Could that be the problem here?

szaimen · 2020-04-23T20:05:05Z

@NOTNlCE @mwllgr @Chillstice
Are you using external storage? That might be the problem here.

NOTNlCE · 2020-04-23T20:05:57Z

I AM using External storage and have no issues.

mwllgr · 2020-04-23T20:06:03Z

@szaimen Nope, my files are stored locally and not encrypted on the server.

benoitmasson · 2020-04-23T20:19:14Z

Same for me with Firefox 75, in private browsing mode. I get a 401 error when trying to view an image (album listing and miniatures show correctly).

Exact error message in the HTTP response is:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception>
  <s:message/>
</d:error>

Requested URL is https://<myserver>/public.php/webdav/photo.jpg, so replying with a 401 is not surprising… the shared folder token does not appear in it.

Chillstice · 2020-04-23T20:20:09Z

NVM ignore this, it was unrelated

I'm also seeing what might be a related error in the nextcloud log viewer:
Warning | l10n | Failed to load /var/www/cloud/public_html/apps/drop_account/l10n/en.json - json error code: 4

Oh, you know what, this is for an app that lets users delete their account, let me just disable that and retry.

neufeind · 2020-04-23T23:12:55Z

Same error here: NotAuthenticated ... 401
18.0.4 with local storage (but data-dir outside of the webroot), public link to a newly shared folder.
The folder opens, showing a list of files. But clicking on one gives that 401-error.

ghost · 2020-04-23T23:39:43Z

See this bug:
#20132

You need to enable "Allow users on this server to send shares to other servers" in federation sharing, to get rid of 401 or infinite loading

Chillstice · 2020-04-24T00:03:11Z

See this bug:
#20132

You need to enable "Allow users on this server to send shares to other servers" in federation sharing, to get rid of 401 or infinite loading

omg that fixed it for me, but why??!?

Edit:

The problem is we can not tell the difference if it is a remote server grabbing the file or a user, so from my perspective it is a "will not fix" and instead the description needs adjusting.

Atlantis1979 · 2020-07-12T11:53:22Z

See this bug:
#20132

You need to enable "Allow users on this server to send shares to other servers" in federation sharing, to get rid of 401 or infinite loading

After hours of research, this is the only thing that worked for me too. Thank you for saving me from madness.

This comment has been minimized.

Sign in to view

Mikescops added the 0. Needs triage Pending approval or rejection. This issue is pending approval. label Jan 19, 2020

This comment has been minimized.

Sign in to view

skjnldsv added the bug Something isn't working label Jan 19, 2020

skjnldsv added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Jan 19, 2020

skjnldsv added this to the 1.1.0 milestone Jan 19, 2020

skjnldsv changed the title ~~No preview in shared folder~~ Photos for public links Jan 21, 2020

This was referenced Jan 21, 2020

Viewer also for public links nextcloud/viewer#89

Closed

1.0.0 shared link with NC Hub 18.0 album view not working #149

Closed

skjnldsv added the high High priority label Feb 2, 2020

This comment has been minimized.

Sign in to view

This was referenced Feb 7, 2020

Gallery-view for shared photos-folders not available #182

Closed

NC18: Sharing Photo-Galleries not working nextcloud/server#19019

Closed

This comment has been minimized.

Sign in to view

szaimen mentioned this issue Feb 14, 2020

Upgade to Nextcloud 18 nextcloud-snap/nextcloud-snap#1247

Closed

This comment has been minimized.

Sign in to view

neufeind mentioned this issue Apr 24, 2020

Public shares return 401 with federation disabled nextcloud/server#20132

Closed

Slideshow photos for public links #128

Slideshow photos for public links #128

Comments

schaze commented Jan 18, 2020 • edited Loading

skjnldsv commented Jan 18, 2020

schaze commented Jan 18, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

skjnldsv commented Jan 19, 2020

menaceone commented Feb 1, 2020

Sandman0984 commented Feb 4, 2020

This comment has been minimized.

This comment has been minimized.

grenzverkehr commented Feb 9, 2020

This comment has been minimized.

This comment has been minimized.

hroling commented Feb 13, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

hroling commented Mar 23, 2020

skjnldsv commented Mar 23, 2020

hroling commented Mar 23, 2020

ainola commented Mar 24, 2020

skjnldsv commented Mar 24, 2020

jhesketh commented Mar 24, 2020

menaceone commented Mar 24, 2020

adsworth commented Mar 24, 2020

BotoX commented Mar 24, 2020

skjnldsv commented Mar 24, 2020

skjnldsv commented Mar 24, 2020 • edited Loading

hroling commented Mar 24, 2020

Leon5x commented Mar 29, 2020

jean-io commented Mar 30, 2020 • edited Loading

skjnldsv commented Mar 30, 2020

Chillstice commented Apr 23, 2020

NOTNlCE commented Apr 23, 2020

mwllgr commented Apr 23, 2020

Chillstice commented Apr 23, 2020

szaimen commented Apr 23, 2020 • edited Loading

szaimen commented Apr 23, 2020

NOTNlCE commented Apr 23, 2020 • edited Loading

mwllgr commented Apr 23, 2020

benoitmasson commented Apr 23, 2020 • edited Loading

Chillstice commented Apr 23, 2020 • edited Loading

NVM ignore this, it was unrelated

neufeind commented Apr 23, 2020

ghost commented Apr 23, 2020 • edited by ghost Loading

Chillstice commented Apr 24, 2020 • edited Loading

Atlantis1979 commented Jul 12, 2020

schaze commented Jan 18, 2020 •

edited

Loading

schaze commented Jan 18, 2020 •

edited

Loading

hroling commented Feb 13, 2020 •

edited

Loading

skjnldsv commented Mar 24, 2020 •

edited

Loading

jean-io commented Mar 30, 2020 •

edited

Loading

szaimen commented Apr 23, 2020 •

edited

Loading

NOTNlCE commented Apr 23, 2020 •

edited

Loading

benoitmasson commented Apr 23, 2020 •

edited

Loading

Chillstice commented Apr 23, 2020 •

edited

Loading

ghost commented Apr 23, 2020 •

edited by ghost

Loading

Chillstice commented Apr 24, 2020 •

edited

Loading