Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search-filter for notes list doesn't use the notes' contents [$20] #288

Closed
korelstar opened this issue Jan 6, 2019 · 4 comments · Fixed by #600
Closed

Search-filter for notes list doesn't use the notes' contents [$20] #288

korelstar opened this issue Jan 6, 2019 · 4 comments · Fixed by #600
Labels
bounty There is a bounty for this issue enhancement New feature or request feature: app navigation Related to the app navigation feature: backend Related to the PHP backend
Milestone

Comments

@korelstar
Copy link
Member

korelstar commented Jan 6, 2019

Due to the speed optimization in #233, the content of the notes is not loaded anymore when loading the notes list. This is still a good decision, but as a consequence filtering notes using a keyword (resp. search string) doesn't "search" in the notes' contents - since filtering is performed on the client. Currently, filtering uses metadata such as the note's title, path, and category, only.

In order to (re-)introduce filtering by notes' contents, we have to implement a server-side search. Of course, the search should be performed asynchronously and has to cope with network errors, users who type faster than the network connection etc. (you know that stuff).


There is a $20 open bounty on this issue. Add to the bounty at Bountysource.

@korelstar korelstar added the enhancement New feature or request label Jan 6, 2019
@korelstar korelstar added feature: app navigation Related to the app navigation feature: backend Related to the PHP backend labels May 24, 2019
@doc75
Copy link

doc75 commented Jan 4, 2020

This feature is really important to ensure Notes is usable.
Can't we imagine to integrate something like https://lunrjs.com/
It requires only to generate the index on server side and then to serve the index when search is launched (size of the index would be from 110s of KB for a resaonable number of notres)

Not sure if this is realistic or not.

@g-work
Copy link

g-work commented Jan 22, 2020

I like the simple UI of the note app, but with hundreds of notes, it is nearly impossible to find the one you're looking for by only searching the title. Unfortunately I'm not able to provide code myself, but i posted a bounty on it - perhaps there are more of you, who are interested in a solution and want to join?

@korelstar korelstar added the bounty There is a bounty for this issue label Jan 26, 2020
@jospoortvliet jospoortvliet changed the title Search-filter for notes list doesn't use the notes' contents Search-filter for notes list doesn't use the notes' contents [$10] Mar 25, 2020
@jospoortvliet jospoortvliet changed the title Search-filter for notes list doesn't use the notes' contents [$10] Search-filter for notes list doesn't use the notes' contents [$20] Mar 26, 2020
@fajabird
Copy link

fajabird commented Apr 26, 2020

The deck app provides a indexer plugin, can't that be used? Indexed search should be supported with the official fulltextsearch engine.

@korelstar korelstar added this to the 3.7.0 milestone Aug 22, 2020
@korelstar
Copy link
Member Author

With Nextcloud 20, a new search API was introduced. Therefore, we need to switch to the new "Unified search API", see nextcloud/server#20916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty There is a bounty for this issue enhancement New feature or request feature: app navigation Related to the app navigation feature: backend Related to the PHP backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants