Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Emoji): Suggest emojis based on text smiles #3923

Merged
merged 1 commit into from
Mar 24, 2023
Merged

feat(Emoji): Suggest emojis based on text smiles #3923

merged 1 commit into from
Mar 24, 2023

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Mar 23, 2023 •
edited by nickvergessen
Loading

See #3924 (comment) for more details

Todo

  • ⚠️ This PR is untested! Properly test it.

@mejo- mejo- added bug Something isn't working 2. developing Work in progress feature: emoji picker Related to the emoji picker component labels Mar 23, 2023
@mejo- mejo- mentioned this pull request Mar 23, 2023
Closed
@mejo- mejo- force-pushed the fix/emoticon_search branch 2 times, most recently from a86526e to 332b3be Compare March 23, 2023 23:42
@nickvergessen nickvergessen mentioned this pull request Mar 24, 2023
Merged
@mejo- @nickvergessen
feat(Emoji): Suggest emojis based on text smiles
c0c10b9 
Search for `:<search-query>` first and fill up missing results with
`<search-query>` (stripping the `:`). This improves results for emoji
autocompletion when typing emoticons (like `:)`, `:D`, `:P` and so on).

Signed-off-by: Jonas <[email protected]>
@nickvergessen nickvergessen changed the title Fix emoticon autocompletion feat(Emoji): Suggest emojis based on text smiles Mar 24, 2023
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 24, 2023
@nickvergessen nickvergessen added this to the 7.8.4 milestone Mar 24, 2023
@nickvergessen nickvergessen marked this pull request as ready for review March 24, 2023 09:45
@nickvergessen
Copy link
Contributor

I adjusted the commit message and title to indicate that it's an additional feature (see #3924 (comment) for explanation), so the follow up would now be up for review as well

marcoambrosini
marcoambrosini approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@nickvergessen nickvergessen merged commit 05badfb into master Mar 24, 2023
@nickvergessen nickvergessen deleted the fix/emoticon_search branch March 24, 2023 10:14
@nickvergessen nickvergessen mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: emoji picker Related to the emoji picker component
Projects
None yet
Milestone
7.8.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mejo- @nickvergessen @AndyScherzinger @marcoambrosini