Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prop type check for NcPopover setReturnFocus #3803

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix prop type check for NcPopover setReturnFocus #3803

merged 1 commit into from
Feb 21, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Feb 21, 2023 •
edited
Loading

This fixes the invalid prop type check for NcPopover setReturnFocus. As per the focus-trap docs, allowed values are
HTMLElement | SVGElement | string | Boolean, see
https://github.com/focus-trap/focus-trap/blob/4cbbef5e971bcdadcc07c3cbb08d0fccfc001809/index.d.ts#L4-L5

Fixes #3801.

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: popover Related to the popovermenu component regression Regression of a previous working feature labels Feb 21, 2023
@raimund-schluessler raimund-schluessler added this to the 7.7.0 milestone Feb 21, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review February 21, 2023 08:20
tacruc
tacruc approved these changes Feb 21, 2023
View reviewed changes
Copy link

@tacruc tacruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Thanks.

Antreesy
Antreesy approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work properly, according to docs. Would be nice to see it in release ASAP

@raimund-schluessler raimund-schluessler merged commit 3187858 into master Feb 21, 2023
@raimund-schluessler raimund-schluessler deleted the fix/3801/actions-return-focus-type branch February 21, 2023 09:00
@GretaD GretaD mentioned this pull request Feb 21, 2023
Closed
@susnux susnux mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@tacruc tacruc tacruc approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@GretaD GretaD Awaiting requested review from GretaD

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: popover Related to the popovermenu component regression Regression of a previous working feature
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.

NcActions passes invalid type to NcPopover prop setReturnFocus
3 participants
@raimund-schluessler @tacruc @Antreesy