-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NcSelect
: Selected options should not overflow the container
#3759
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ferdinand Thiessen <[email protected]>
319a9f8
to
987e090
Compare
This is caused by
Ah did not noticed that, thank you! Fixed that as well. |
PR for the nextcloud fork of the vue-select: nextcloud-libraries/vue-select#18 (Forgot that we are using a custom fork and not the vanilla upstream) |
.vs__selected-options { | ||
min-width: 0; | ||
.vs__selected { | ||
min-width: 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mh, shall we revert the PR for this release @raimund-schluessler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have a preference here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's a need for rush, so let's try to get this solved before releasing 7.7.0. @susnux would you prefer to look for a fix or to revert the PR for 7.7.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look for a fix.
If the selected option is longer than the element it should not overflow the NcSelect but use ellipsis.
min-width: 0
As you can see currently the option overflows the select, note the actions (dropdown toggle) are missing because they are placed outside the select underneath other elements on the right.
After fixing the overflow there is still this weird height issues, which happens because
.vs__selected-options
haveflex-wrap
set and contain the search input even if it is disabled (searchable=false
).This can be fixed by removing the search input from the visible dom when not used.
I already submitted a upstream PR, but I doubt that it will be merged soon.