Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiselect checkmark and plus icon #3513

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix multiselect checkmark and plus icon #3513

merged 1 commit into from
Nov 23, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Nov 23, 2022
@skjnldsv skjnldsv added this to the 7.1.0 milestone Nov 23, 2022
@skjnldsv skjnldsv requested review from GretaD, szaimen and a team November 23, 2022 09:47
@skjnldsv skjnldsv self-assigned this Nov 23, 2022
@skjnldsv skjnldsv requested review from PVince81 and artonge and removed request for a team November 23, 2022 09:47
This was referenced Nov 23, 2022
Closed
Merged
szaimen
szaimen approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

I suppose this fixes #3306?

@skjnldsv skjnldsv merged commit 7dd77d8 into master Nov 23, 2022
@skjnldsv skjnldsv deleted the fix/multiselect-checkmark branch November 23, 2022 09:58
@skjnldsv skjnldsv mentioned this pull request Nov 23, 2022
Closed
@skjnldsv
Copy link
Contributor Author

I suppose this fixes #3306?

yep

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

@skjnldsv can you maybe create a new vue lib release that contains this fix? :)

@skjnldsv
Copy link
Contributor Author

@szaimen you can do it :)

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

@szaimen you can do it :)

I can check tomorrow morning how to do that. Was there some documentation on this somewhere? Also do I have enough permissions to publish the release to npm?

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 23, 2022 •
edited
Loading

https://github.com/nextcloud/nextcloud-vue#releasing-a-new-version

@szaimen szaimen mentioned this pull request Nov 24, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

#3515

@seyfeb seyfeb mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @szaimen @CarlSchwan