-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DateTimePicker example and translation #3405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
a team,
PVince81,
artonge and
Pytal
and removed request for
a team
October 29, 2022 09:12
skjnldsv
added
bug
Something isn't working
3. to review
Waiting for reviews
feature: datepicker
Related to the date/time picker component
labels
Oct 29, 2022
/backport to stable6 |
szaimen
reviewed
Oct 29, 2022
szaimen
approved these changes
Oct 29, 2022
skjnldsv
force-pushed
the
fix/DateTimePicker
branch
from
October 29, 2022 09:14
a162e57
to
0a16748
Compare
szaimen
approved these changes
Oct 29, 2022
skjnldsv
force-pushed
the
fix/DateTimePicker
branch
from
October 29, 2022 09:17
0a16748
to
a30d922
Compare
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Oct 29, 2022
PVince81
approved these changes
Oct 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CI fails though
Pytal
approved these changes
Oct 31, 2022
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
fix/DateTimePicker
branch
from
November 1, 2022 07:58
a30d922
to
7c2cb3d
Compare
Cypress failures unrelated |
13 tasks
raised #3430 |
Merged
/backport to stable7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
Something isn't working
feature: datepicker
Related to the date/time picker component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3403
Preview: https://deploy-preview-3405--nextcloud-vue-components.netlify.app/#/Components/NcPickers?id=ncdatetimepicker
Regression of #3202