Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also use menuOpen state in NcAppNavigationItem #3350

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Also use menuOpen state in NcAppNavigationItem #3350

merged 1 commit into from
Oct 11, 2022

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Oct 7, 2022

Fix nextcloud/calendar#4574

The open class should be added when menuOpenLocalValue or the prop menuOpen is true.

@st3iny st3iny added bug Something isn't working 2. developing Work in progress labels Oct 7, 2022
@st3iny st3iny added this to the 7.0.0 milestone Oct 7, 2022
@st3iny st3iny self-assigned this Oct 7, 2022
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 7, 2022
@st3iny st3iny marked this pull request as ready for review October 7, 2022 10:25
szaimen
szaimen approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@st3iny st3iny force-pushed the fix/noid/use-menu-open-state branch from 09aa0a0 to eaa3502 Compare October 11, 2022 10:51
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2022
@szaimen szaimen merged commit b82d4e3 into master Oct 11, 2022
@szaimen szaimen deleted the fix/noid/use-menu-open-state branch October 11, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@st3iny st3iny

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Milestone
7.0.0
3 participants
@st3iny @ChristophWurst @szaimen