Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design of related resources panel #3236

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Sep 13, 2022

Before After
image image
  • Using icons instead of repeated subline
  • Have a short explanatory text below the heading as per mockup
  • Whole entry should be clickable

coreApps and appswebroots data was added to resolve some console errors in the styleguide

@Pytal Pytal added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Sep 13, 2022
@Pytal Pytal added this to the 7.0.0 milestone Sep 13, 2022
@Pytal Pytal requested review from jancborchardt and a team September 13, 2022 02:08
@Pytal Pytal self-assigned this Sep 13, 2022
@Pytal Pytal requested review from PVince81, artonge and szaimen and removed request for a team September 13, 2022 02:08
@Pytal Pytal force-pushed the enh/related-resources-design branch from e7195ec to 8597127 Compare September 13, 2022 02:17
@PVince81
Copy link
Contributor

in the original mock up the circles of related resources were aligned with the ones on top

now, it seems the highlight needs some margin anyway to be able to appear, so perhaps it's rather the sharing items that need indenting ? I'm guessing that those don't yet have the new highlight style

@PVince81
Copy link
Contributor

it already looks much better!

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ok to move forward though, indent topic can be addressed separately if needed

Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix dark mode detection

src/components/NcRelatedResourcesPanel/NcResource.vue Outdated Show resolved Hide resolved
src/components/NcRelatedResourcesPanel/NcResource.vue Outdated Show resolved Hide resolved
src/components/NcRelatedResourcesPanel/NcResource.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice already! Some additional feedback (all as per mockup):

Otherwise nice!

@jancborchardt
Copy link
Contributor

Ah and btw, the subline wording

Anything shared eith the same group of people will show up here

is this still how the algorithm works? Or is it drastically different? @ArtificialOwl
If so we might have to reword.

@ArtificialOwl
Copy link

There is 2 pass:

  • The first one is to get all shares on the current displayed item (file, board, room, ...), and for each entity the item is shared to, get the list of shared items.

  • The second one will weight each returned result based on some factors (how many equivalent shares vs total of shares, the timestamp between the shares, keywords, ...)

@Pytal Pytal force-pushed the enh/related-resources-design branch from b57063e to ebc3f7c Compare September 14, 2022 01:43
@Pytal
Copy link
Contributor Author

Pytal commented Sep 14, 2022

Styles + screenshot updated

@Pytal
Copy link
Contributor Author

Pytal commented Sep 14, 2022

@PVince81
Copy link
Contributor

@jancborchardt please recheck the screenshots

note: if we don't get feedback we'll merge anyway later today to get it shipped and further changes will need to happen separately

Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Pytal, looks really great now! :)

@jancborchardt jancborchardt merged commit 4bb374f into master Sep 14, 2022
@jancborchardt jancborchardt deleted the enh/related-resources-design branch September 14, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants