-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update design of related resources panel #3236
Conversation
e7195ec
to
8597127
Compare
in the original mock up the circles of related resources were aligned with the ones on top now, it seems the highlight needs some margin anyway to be able to appear, so perhaps it's rather the sharing items that need indenting ? I'm guessing that those don't yet have the new highlight style |
it already looks much better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ok to move forward though, indent topic can be addressed separately if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix dark mode detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice already! Some additional feedback (all as per mockup):
- The heading and subline:
- Can use even more whitespace above, e.g. 44px Align sharing tab content and increase spacing nextcloud/server#34062
- Should be indented to be left-aligned with the rest of the text as per mockup
- The heading "Related resources" can be bold for better scannability
- The entries
- Should not be bold
- Don't need the starting slash for Files remove prefix slash nextcloud/related_resources#24
- The text alignment with the share part up top as @PVince81 mentioned :)
Otherwise nice!
Ah and btw, the subline wording
is this still how the algorithm works? Or is it drastically different? @ArtificialOwl |
There is 2 pass:
|
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
b57063e
to
ebc3f7c
Compare
Styles + screenshot updated |
Requires release with upstream fixes |
@jancborchardt please recheck the screenshots note: if we don't get feedback we'll merge anyway later today to get it shipped and further changes will need to happen separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Pytal, looks really great now! :)
coreApps
andappswebroots
data was added to resolve some console errors in the styleguide