Limit max width of the settings #3192
Conversation
CarlSchwan
requested review from
jancborchardt,
skjnldsv,
szaimen and
nimishavijay
|
Wouldn't it work better if we just limit the width of h2, h3, etc and p elements by default, not making it options? That would limit the width of the text-based parts, keep layouts of e.g. Logging, and also ensure devs don't forget to set it. So we don't need an option devs need to set. |
|
There is probably more elements we want to limit the width than just p, h1, h2, ... like the notecard components, input fields, and more The idea of @skjnldsv to make it on by default, is probably a good one since nc7.0 is a breaking release anyway. We just need to document somewhere that if someone is using NcSettingSection to check if they might want to disable this behavior (e.g. activity app) |
CarlSchwan
force-pushed
the
limit-max-width-settings
branch
from
d6b37a1
to
8d05f6e
Compare
| @@ -117,12 +130,17 @@ export default { | |||
| border-bottom: 1px solid var(--color-border); | |||
| } | |||
|
|
|||
| &--limit-width > * { | |||
| max-width: 900px; | |||
There was a problem hiding this comment.
| max-width: 900px; | |
| max-width: $maxWidth; |
This option only apply to the title and description by default and is opt-in for the content. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
limit-max-width-settings
branch
from
8d05f6e
to
62ca1e3
Compare
|
Ok, sounds good. The admin Logging app is definitely one which needs an exception, but I think it's written in React anyway @icewind1991? |
it is, same with the groupfolder app. At some point we need to move that to vue but this can probably wait :) |
This option only apply to the title and description by default and is opt-in for the content.