Allow ListItem components to link to external links #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
marcoambrosini,
jotoeri,
a team,
juliusknorr and
CarlSchwan
and removed request for
a team
skjnldsv
reviewed
Aug 17, 2022
tcitworld
force-pushed
the
allow-listitems-to-have-external-links
branch
from
e9b4dc2
to
5d4d7b6
Compare
skjnldsv
reviewed
Aug 18, 2022
skjnldsv
approved these changes
Aug 18, 2022
Closes #3039 Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
force-pushed
the
allow-listitems-to-have-external-links
branch
from
5d4d7b6
to
5ba557d
Compare
artonge
approved these changes
Aug 18, 2022
Merged
jotoeri
reviewed
Aug 18, 2022
Comment on lines
+195
to
+196
| target="_blank" | ||
| rel="noopener noreferrer" |
There was a problem hiding this comment.
These two now always apply! This breaks the component.
There was a problem hiding this comment.
Shouldn't it be harmless on a <a href="#"> tag? How does it break it?
There was a problem hiding this comment.
Yes, we use @click for it, no?
There was a problem hiding this comment.
Yes, but the target blank seems to kick in before click is emitted. Thus the appnavigation on forms now opens a new tab with the link instead of triggering the router.
There was a problem hiding this comment.
#3069 should do it. Click event would have a different behaviour if e.preventDefault() wouldn't be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3039
I didn't do anything UI-wise to distinguish external links (which use
target="_blank", but we could change that).