-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon-class, re-add default-icon support for Actions #3017
Conversation
Signed-off-by: Raimund Schlüßler <[email protected]>
a313166
to
9d29c3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably make sense to at some point have a slot for material icon since we are migrating to that slowly in other places.
But definitively not blocking or urgent, let's first get back default-icon
so we can port our apps to Nextcloud Vue 6 :)
Thanks!
The component has a slot already, so you can start migrating immediately 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Vincent Petry <[email protected]>
I did some migrations already back then on Talk and remember that it wasn't always straightforward because you had to find a matching MD icon and sometimes styles started to go crazy. This is why I wouldn't want to rush removing the icon attribute support. |
Last week I replaced a lot of icons and buttons in Talk, it was mostly all pretty straight forward |
This brings back the support for a
default-icon
and fixes the support oficon
for theActions
component.Follow-up to #3006, fixes #3016.
Please test this well, I only checked in in the docs.