Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also export tooltip options #2999

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

raimund-schluessler
Copy link
Contributor

This adds an export of the tooltip options object, so one can customize the tooltips if necessary.

Works like this:

import { options as TooltipOptions } from '@nextcloud/vue/dist/Directives/Tooltip'
TooltipOptions.container = '#content-vue'

Closes #2993.

Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews regression Regression of a previous working feature feature: tooltip Related to the tooltip directive bug Something isn't working labels Aug 10, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 10, 2022
@nickvergessen
Copy link
Contributor

Thank you very much

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raimund-schluessler raimund-schluessler merged commit 4191490 into master Aug 10, 2022
@raimund-schluessler raimund-schluessler deleted the fix/2993/export-tooltip-options branch August 10, 2022 20:05
@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: tooltip Related to the tooltip directive regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip default options are not changable anymore in v6.0
3 participants