Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions from floating-vue migration #2997

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Aug 10, 2022

This PR fixes two regressions from the migration to floating-vue in #2600. The RichContenteditable tooltip open variable name was not adjusted and the tooltip top arrow style was broken.

Before (tooltip only shown on hover):
Bildschirmfoto vom 2022-08-10 17-08-27

After (tooltip automatically shown):
Bildschirmfoto vom 2022-08-10 17-10-32

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: tooltip Related to the tooltip directive feature: rich-contenteditable Related to the rich-contenteditable components labels Aug 10, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 10, 2022
@raimund-schluessler raimund-schluessler marked this pull request as ready for review August 10, 2022 15:12
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 55f35d6 into master Aug 10, 2022
@PVince81 PVince81 deleted the fix/noid/floating-vue-regressions branch August 10, 2022 19:56
@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components feature: tooltip Related to the tooltip directive regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants