-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessible EmptyContent component #2867
Conversation
a4b50a5
to
6163cbb
Compare
Would it make sense to recommend adding the accessible title prop to EmptyContent icons @nimishavijay? It would show a tooltip like below whenever you hover over the icon |
63d65e0
to
26884e0
Compare
I would say this image is decorative, as all the information required by a person on this page is given through the text. If the purpose of a |
Yep, as so often the icon is decorative and has its text there as h2, and thus should have empty alt text |
- Drop support for class based icons - Title is now optional Signed-off-by: Christopher Ng <[email protected]>
26884e0
to
7282eb7
Compare
Close #2500
To Do
svg
markup https://github.com/robcresswell/vue-material-design-icons/blob/5.1.2/build.ts#L20-L28role="img"
https://github.com/robcresswell/vue-material-design-icons/blob/5.1.2/build.ts#L18aria-hidden
attribute https://github.com/robcresswell/vue-material-design-icons/blob/5.1.2/build.ts#L15