Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with eslint for event name #2603

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 5, 2022

Breaking change.

Follow-up of #2594

@artonge artonge added the 2. developing Work in progress label Apr 5, 2022
@artonge artonge added this to the 6.0.0 milestone Apr 5, 2022
@raimund-schluessler raimund-schluessler added the breaking PR that requires a new major version label Apr 5, 2022
Breaking change.

Follow-up of #2594
@raimund-schluessler
Copy link
Contributor

Since we anyway have breaking changes in master now, it's a good time to merge this as well.

@skjnldsv
Copy link
Contributor

skjnldsv commented Jun 1, 2022

Breaking change.

Is it? I thought vue was smart enough to understand kebab/pascal cases ?

@raimund-schluessler
Copy link
Contributor

Breaking change.

Is it? I thought vue was smart enough to understand kebab/pascal cases ?

I didn't check it this time, but I am pretty sure it is. The last time I had to fix this in Tasks, it just didn't work anymore. Without any hint or ideally compile time warning.

@GretaD
Copy link
Contributor

GretaD commented Jun 1, 2022

Breaking change.

Is it? I thought vue was smart enough to understand kebab/pascal cases ?

I didn't check it this time, but I am pretty sure it is. The last time I had to fix this in Tasks, it just didn't work anymore. Without any hint or ideally compile time warning.

yep, it happened to me on mail too

@raimund-schluessler raimund-schluessler merged commit 8fc2773 into master Jun 1, 2022
@raimund-schluessler raimund-schluessler deleted the artonge-patch-1 branch June 1, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews breaking PR that requires a new major version technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants