Improve multiselect tag #1718
Merged
Improve multiselect tag #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
GretaD
force-pushed
the
fix/multiselect_tag
branch
3 times, most recently
from
26cac34
to
8233460
Compare
GretaD
added
3. to review
skjnldsv
requested changes
Mar 1, 2021
This comment has been minimized.
This comment has been minimized.
GretaD
force-pushed
the
fix/multiselect_tag
branch
2 times, most recently
from
7aab020
to
b3b3f94
Compare
skjnldsv
reviewed
Mar 8, 2021
Comment on lines
103
to
105
| max-width: 50%; | ||
| max-width: fit-content; | ||
| max-width: -moz-fit-content; |
There was a problem hiding this comment.
Why was this removed?
This doesn't look like it have something to do with this pr :)
skjnldsv
approved these changes
Mar 8, 2021
Signed-off-by: GretaD <[email protected]>
GretaD
force-pushed
the
fix/multiselect_tag
branch
from
b3b3f94
to
6b30c4f
Compare
ChristophWurst
approved these changes
Mar 9, 2021
ChristophWurst
added
4. to release
This was referenced Mar 11, 2021
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we select an item from the multiselect dropdown, the item it is not shown in the input field while the dropdown is active. This bring a lot of confusion to users as they are not sure if they selected smth or not. This PR fixes that.