Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loadTranslations): Handle edge cases #644

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 25, 2023

Should not happen, but lets be defensive and handle even the cases where the server might return invalid data.
(thanks @ code coverage that notified there is a missing test for this branch).

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.61 🎉

Comparison is base (445771a) 83.95% compared to head (a605fd2) 84.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   83.95%   84.57%   +0.61%     
==========================================
  Files           6        6              
  Lines         187      188       +1     
  Branches       67       67              
==========================================
+ Hits          157      159       +2     
  Misses         28       28              
+ Partials        2        1       -1     
Impacted Files Coverage Δ
lib/translation.ts 70.70% <100.00%> (+1.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skjnldsv skjnldsv merged commit 03070c9 into master Jun 25, 2023
@skjnldsv skjnldsv deleted the fix/handle-edge-cases-load-translations branch June 25, 2023 13:30
@skjnldsv
Copy link
Contributor

I just stopped the release, do you want to have this in 2.2.0 ?

@susnux
Copy link
Contributor Author

susnux commented Jun 25, 2023

One second too late 😅

I just stopped the release, do you want to have this in 2.2.0 ?

Not necessary but would be nice 😄

@skjnldsv
Copy link
Contributor

Not necessary but would be nice smile

I'll let you release then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants