Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable contextmenu "place photo folder" that was removed in the past #290

Closed
wronny opened this issue Feb 7, 2020 · 3 comments
Closed

Comments

@wronny
Copy link
Member

wronny commented Feb 7, 2020

Hello,
I'm like to use maps to add pictures. Unfortunately contextmenu "place photo" only allow to add single photo or several using ctrl+mouseclick. However this is not very comfortable to select many photos. While investigating on adding photos by folder I stumbled over "place photo folder" in script.js. Unfortunately this has been removed / commented in the past:

grafik

I tested using my nc18 maps to re-add this contextmenu item and surprisingly "place photo folder" was working without any further modification.
Is there any reason that I might have missed that "place photo folder" should be kept disabled? Maybe it is just still disabled just because it has been forgotten to re-enable it again?
Maybe someone else likes to verify my observation?
Many thanks
Wronny

@wronny
Copy link
Member Author

wronny commented Feb 9, 2020

addendum: If I use "place photo folder" re-enabled in js/script.js it takes about a minute until new added photos are shown on map. Not sure why this is different to (single) "place photo" that does show the added photo immediately.

@jancborchardt
Copy link
Member

@wronny would you like to open a pull request to add this back? And maybe you can look into the issue of the delay until photos are shown on the map? :)

@jancborchardt jancborchardt removed their assignment Feb 25, 2020
julien-nc pushed a commit that referenced this issue Feb 25, 2020
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc pushed a commit that referenced this issue Feb 25, 2020
@wronny
Copy link
Member Author

wronny commented Feb 27, 2020

fixed by #316
Many thanks to @eneiluj

@wronny wronny closed this as completed Feb 27, 2020
julien-nc pushed a commit that referenced this issue Feb 29, 2020
julien-nc pushed a commit that referenced this issue Feb 29, 2020
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc pushed a commit that referenced this issue Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants