-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8.2 support #983
Comments
Thanks! |
Can you test #985 ? |
Simply by downloading the new package-lock.json and putting it into the maps directory? |
I think you will need the package.json, too |
As you have already merged your change to master I just cloned the repo and compiled it. |
I get several error messages at my NC log (upgraded to 26.0.0 RC1):
|
I just tried the regular app from the NC app store. There are also some log entries:
|
The second one is a duplicate of #948 |
How do I verify the signing status? |
In the admin settings somewhere. |
Ah okay the regular Nextcloud signing status. Also the integrity check didn't show any errors. I just pulled the current master repo and modified it for PHP8.2 and compiled it with the above mentioned npm commands. |
#984 |
Where are the dependencies listed? |
composer.json |
Thanks. I just crosschecked my NC folders now + the error message.
But I wasn't able to find this file. |
Sorry maybe I forgot, you should probably also run |
Thanks - the With my little dev knowledge I have just done what the shell recommended and ran After that the whole make process was running without any error message regarding maps.
I then moved the compiled maps app to Nextcloud and enabled it. |
Yes the problem is that after composer update |
Also NC25 supports php8.0 and php8.1, but not php8.2 |
Ah okay so the issue comes from older PHP versions.. Would it work to ship dependencies for more PHP versions within the same app and the client uses the right one depending on the local version? |
I don't know how. |
@tacruc Is it possible to release a new version that supports PHP8.2/Nextcloud 26? I understand that the nightly releases are already supposed to support it (correct?), but they cannot be installed through This prevents me from upgrading to Nextcloud 26 (or I would have to disable the app). In turn, this prevents me from upgrading to Debian 12, as the only supported PHP version in Debian 12 is 8.2. Or is there something blocking for a new release? Thanks in advance. |
Could you test v1.1.0-nightly? |
Sorry for the late feedback, it appears to work perfectly, thanks! |
How to use GitHub
Is your feature request related to a problem? Please describe.
I am running the current NC 26 beta 5 to test/use PHP8.2 FPM.
I just recognised that Maps is not supporting it so I edited the info.xml the bypass the restriction.
So far the Maps app works but if I move the map it hangs sometimes.
Zooming in & out again usually solves the problem.
I think this is a similar problem to #786
Describe the solution you'd like
Make Maps compatible to PHP 8.2
Describe alternatives you've considered
Additional context
I am currently using v0.2.5-9-nightly
The text was updated successfully, but these errors were encountered: