Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l10n: Add plural handling to a few js strings #497

Open
rakekniven opened this issue Nov 10, 2020 · 8 comments
Open

l10n: Add plural handling to a few js strings #497

rakekniven opened this issue Nov 10, 2020 · 8 comments

Comments

@rakekniven
Copy link
Member

Reported at Transifex.

maps/src/photosController.js

Line 633 in 9cdfbe1

OC.Notification.showTemporary(t('maps', '{nb} photos placed', {nb: response}));

@Valdnet

This comment was marked as outdated.

Sign in to view
@rakekniven
Copy link
Member Author

@eneiluj You maybe?

@Valdnet
Copy link
Contributor

Valdnet commented Mar 19, 2021

ping @eneiluj

@tacruc
Copy link
Collaborator

tacruc commented Jun 16, 2022

Is it fixed in the new frontend?

@rakekniven
Copy link
Member Author

No, AFAICS from code.

@tacruc
Copy link
Collaborator

tacruc commented Jun 21, 2022

The correct files is now:

maps/src/views/App.vue

Line 1726 in 883e537

showSuccess(t('maps', '{nb} devices imported from {path}', { nb: response.data, path }))

@rakekniven
Copy link
Member Author

But the file I linked to in my initial post is still there in master branch?

@tacruc
Copy link
Collaborator

tacruc commented Jun 27, 2022

The old JS code is not yet removed.
Working on it see #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tacruc @rakekniven @Valdnet