Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag modal: click on tag to apply (instead of button next to it) #9215

Open
alexanderdd opened this issue Jan 4, 2024 · 2 comments
Open

tag modal: click on tag to apply (instead of button next to it) #9215

alexanderdd opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
1. to develop design enhancement papercut Annoying recurring issue with possibly simple fix.

Comments

@alexanderdd
Copy link

Is your feature request related to a problem? Please describe.

  1. open the tag modal of an email
  2. see this (German version):
    Bildschirmfoto vom 2024-01-04 21-59-30
  3. hover over the name of the first tag "Später" (=later) -> cursor changes to hand - looks like I can click on it!
  4. no, I cannot click on it
  5. how do I apply the tag?
  6. oh there is a button to the right...

Describe the solution you'd like

Click on the name of a tag to apply it.
Remove the "apply tag" buttons.

Describe alternatives you've considered

Additional context

@ChristophWurst ChristophWurst added 1. to develop design papercut Annoying recurring issue with possibly simple fix. and removed 0. to triage labels Oct 16, 2024
@ChristophWurst
Copy link
Member

@nimishavijay I think it's best to think about the overall design of this modal. There are plenty of quirks. Technically the modal can do everything one might need, but it's just not very convenient to do so. Could you work on this and create specs/mockups for our engineers?

@nimishavijay
Copy link
Member

So here's a good place to start:

Image

Overall changes:

  • Use only one heading "Add tags" with the appropriate heading number and styling (should be h2, I think?)
  • Use the standard size for the "small" modal (300px)
  • Each row has:
    • checkbox component with tag on the inside
    • 3 dot menu with Edit tag and Delete tag (currently there seems to be a bug that the default tags don't have a delete action unless you click on "Edit name or color", so that should be fixed too)
    • gap between rows is --default-grid-baseline
  • Each tag has:
    • bold font
    • height 28px
    • left and right padding 8px
  • Add tag button:
    • "Add tag" --> "Add new tag" (to distinguish it from the modal title)
    • button goes at the bottom on the left
    • uses tertiary button styling
  • Have a "Done" button at the end to save changes

Adding a new tag:

  • when you click on the "Add new tag" button, a new row is created with an input field and a color picker

Editing tag:

  • when you click on Edit tag in the 3 dot menu for a tag, the checkbox items changes into a color dot and an input field inline

Deleting tag:

  • Should again be a small size (300px) and use correctly formatted headings
  • Change the wording inside the dialog to also contain the name of the tag that will be deleted (to prevent misclicks) and make sure the user knows that no emails will be removed --> "The tag "Later" will be removed from all messages. Deleting a tag does not delete any messages."

In the future, we can have some more features such as a search bar in this dialog for searching for a tag, etc. What do you think?

@nimishavijay nimishavijay moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop design enhancement papercut Annoying recurring issue with possibly simple fix.
Projects
Status: 🏗️ At engineering
Development

No branches or pull requests

3 participants