Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen default width of AppContentList #6973

Closed
2 tasks done
ChristophWurst opened this issue Aug 11, 2022 · 7 comments · Fixed by #7127
Closed
2 tasks done

Widen default width of AppContentList #6973

ChristophWurst opened this issue Aug 11, 2022 · 7 comments · Fixed by #7127

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Aug 11, 2022

Is your feature request related to a problem? Please describe.

Second column is too narrow by default

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

No response

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Aug 12, 2022

https://nextcloud-vue-components.netlify.app/#/Components/App%20containers/AppContent?id=appcontent-1 has a percentual init value for listSize. We don't set anything in Mail at the moment, so it's 20%. How far should we go up @jancborchardt?

@ChristophWurst
Copy link
Member Author

If we assume a screen of 1080px there are 300px for the nav and 780 for the content. 300px/780px is 38%. Would it be ok to use seomthing like that as new default?
The current max width is 40%. If we go near that for the default width we should probably increase that.

@jancborchardt
Copy link
Member

20% seems fine, but we should probably have a min-width of 300px (same as AppNavigation) as well.

@ChristophWurst
Copy link
Member Author

Min/max are also defined as percentage. The component default is 15 as min, 40 as max.

@ChristophWurst
Copy link
Member Author

min-width of 300px

The shallowest window width with three columns is 1024px. With the sidebar collapsed we are at 30% for the message list to be at ~300px. With the open sidebar it's ~40% for 280px.

How about we change the min to 25%? The only downside could be very large screens. Like on a 4k screen with 2160px width the column would be at least 540px wide.

@ChristophWurst
Copy link
Member Author

Alternatively we could look into changing the @nextcloud/vue component to also allow pixel values for the props.

@ChristophWurst
Copy link
Member Author

@skjnldsv what do you think? Would it make sense to offer pixels as alternative? The percentile min/max is tricky to get right for various browser widths. Any other ideas?

@ChristophWurst ChristophWurst moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team Sep 1, 2022
@ChristophWurst ChristophWurst self-assigned this Sep 1, 2022
Repository owner moved this from 🏗️ In progress to ☑️ Done in 🖍 Design team Sep 1, 2022
Repository owner moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants