Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature parity] Version naming/deletion #2310

Closed
XueSheng-GIT opened this issue Mar 28, 2023 · 4 comments
Closed

[Feature parity] Version naming/deletion #2310

XueSheng-GIT opened this issue Mar 28, 2023 · 4 comments
Labels
0. Needs triage Issues that need to be triaged enhancement feature: versions Items related to file versioning

Comments

@XueSheng-GIT
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Version naming/deletion was introduced with Nextcloud Hub 4 (v26). See nextcloud/server#35160. But this Feature is disabled if groupfolders app is activated!

Describe the solution you'd like
Groupfolders should be extended to feature version naming/deletion, same as on the default nextcloud storage.

Describe alternatives you've considered
Disabling groupfolders makes it possible to use version naming/deletion on the default storage, but then you'll loose the groupfolder features.

Additional context
n/a

@XueSheng-GIT XueSheng-GIT added 0. Needs triage Issues that need to be triaged enhancement labels Mar 28, 2023
@AndyXheli
Copy link

Same issue

@Jerome-Herbinet
Copy link
Member

Jerome-Herbinet commented May 10, 2023

@artonge are you aware of that ? Is this issue in the right place ; should it be moved to the "server" project ?
... that said is it's really related to the following feature : #35160

PS : Same issue noticed by my side

@artonge
Copy link
Contributor

artonge commented May 10, 2023

Group folder as well as S3 versioning have their own versioning backends, so we need to adapt the feature for those backends. Hence the restriction when those apps are enabled.

Not sure how much work this would require, and this is not planned yet, so if anyone wants to jump on it, fell free :)

@XueSheng-GIT
Copy link
Contributor Author

Fixed with #2543

@joshtrichards joshtrichards added the feature: versions Items related to file versioning label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged enhancement feature: versions Items related to file versioning
Projects
None yet
Development

No branches or pull requests

5 participants