Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Permission Rules order matters, not working as documented #2043

Closed
francofischer opened this issue Jul 25, 2022 · 4 comments
Closed
Labels
0. Needs triage Issues that need to be triaged bug feature: acl Items related to the groupfolders ACL or "Advanced Permissions"

Comments

@francofischer
Copy link

Hi,

I'm runnning Nextcloud v24.0.3 with Group Folders v12.0.1. I found a bug in the Advanced Permissions behavior.

The documentation states that if a user belongs to 2 different grups with different permissions, the most permissive rule will stand:

imagen

However, in practice only the rule at the top actually stands, and the order of those rules depend on how the rules are set. The order cannot be set manually.

This is the situation we are seeing:

A user belongs to both groups: "Everyone" and "Admins_compartida". If rules look like the following image, then the user can read the files.
imagen

But, if I modify the rules and the order changes (still trying to figure out why or how the order is affected), and the rules are set as the next image, then the same user can not access the files.
imagen

@francofischer francofischer added 0. Needs triage Issues that need to be triaged bug labels Jul 25, 2022
@francofischer
Copy link
Author

Might be related to this issue #1212

@reos-rcrozier
Copy link

Is this bug still present? If so, the documentation should at least be updated to mention that the rule order matters, and perhaps explain a workaround (how to get the rules in a desired order of precedence).

@joshtrichards joshtrichards added the feature: acl Items related to the groupfolders ACL or "Advanced Permissions" label Sep 30, 2023
@vbier
Copy link

vbier commented Nov 21, 2023

I can explain the difference in behaviour, even though I can not understand how one would decide to implement it as it has been.

The difference in your case is that the rule for admins_compertida in your second screen shot is inherited from a parent folder (this can be seen by the missing x button right of the rule). Developers decided that permissiions in a child always override parent permission setting, even though they might originate from different groups. So if you get a permissions though group A in the parent folder and it is revoked through group B in the child, people that are in both groups do not have permission to the file.

This is described in detail in issue #1212. So this issue can be closed and marked as duplicate of #1212

@fschrempf
Copy link
Contributor

Duplicate of #1212

@fschrempf fschrempf marked this as a duplicate of #1212 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged bug feature: acl Items related to the groupfolders ACL or "Advanced Permissions"
Projects
None yet
Development

No branches or pull requests

5 participants