fulltextsearch:index always scans all files even if index is already available

[jensgoe]

I spent some time to debug this issue. The problem must something have to do with the changes for "default collection is local".

The database rows in table "oc_fulltextsearch_index" are stored with an empty string for the collection column. The function getIndex() in "lib/Db/IndexesRequest.php" is filtering with value "local" for the collection column. Thats why the check, if a file is already in the index always fails.

[jensgoe]

similar issue might be #723

[XueSheng-GIT]

@jensgoe can you add some steps how to reproduce? Maybe also how you did reset your index.

[jensgoe]

It was quite easy to reproduce it:

1. call php occ fulltextsearch:index
2. wait until it is finished
3. call php occ fulltextsearch:index again

expected: skip already indexed files
actual: all files are indexed again, even if nothing has changed.

i fixed it locally for me by modifying file ./apps/fulltextsearch/lib/Model/Index.php.
I initialized the private field collection with "local" and ensured that it stays the value local if an empty value is set:

*** 55,61 ****
        /** @var string */
        private $documentId;

!       private string $collection = '';

        /** @var string */
        private $source = '';
--- 55,61 ----
        /** @var string */
        private $documentId;

!       private string $collection = CollectionService::LOCAL;

        /** @var string */
        private $source = '';
***************
*** 89,95 ****
        public function __construct(string $providerId, string $documentId, string $collection = '') {
                $this->providerId = $providerId;
                $this->documentId = $documentId;
!               $this->collection = $collection;
        }


--- 89,95 ----
        public function __construct(string $providerId, string $documentId, string $collection = '') {
                $this->providerId = $providerId;
                $this->documentId = $documentId;
!               $this->collection = ($collection === '') ? CollectionService::LOCAL : $collection;
        }


***************
*** 152,158 ****
         * @return Index
         */
        public function setCollection(string $collection): self {
!               $this->collection = $collection;

                return $this;
        }
--- 152,158 ----
         * @return Index
         */
        public function setCollection(string $collection): self {
!               $this->collection = ($collection === '') ? CollectionService::LOCAL : $collection;

                return $this;
        }

sorry for the bad diff.

The last days some commits already changed that. It might be fixed with commit 0021dc7

[XueSheng-GIT]

The last days some commits already changed that. It might be fixed with commit 0021dc7

@jensgoe did check the latest release? The changes you mentioned are included.

[jensgoe]

tested with 27.0.2 and it worked. Thanks. Closing this issue